[DevTools] Added keyboard search while in sources

third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 25 matching lines @@
     this._createRootElement();
 
     this.selectedTreeElement = null;
     this.expandTreeElementsWhenArrowing = false;
     /** @type {?function(!TreeElement, !TreeElement):number} */
     this._comparator = null;
 
     this._contentElement = this._rootElement._childrenListNode;
     this._contentElement.addEventListener("keydown", this._treeKeyDown.bind(this), true);
 
+    this.element = this._contentElement;
+
     this.setFocusable(!nonFocusable);
 
-    this.element = this._contentElement;
+    this._contentElement.addEventListener("keypress", this._handleKeyPressForHighlighting.bind(this), true);

[lushnikov, 2016/04/06 00:22:36]

this.element.addEventListener...

[allada, 2016/04/09 00:42:47]

Done.

+    this.element.addEventListener("blur", this._clearFilter.bind(this), true);

[lushnikov, 2016/04/06 00:22:36]

is capturing actually needed in these three events?

+    this.element.addEventListener("click", this._clearFilter.bind(this), true);
+
+    this._currentSelectionFilterString = "";
+    this._interactiveFilterEnabled = false;
+    /** @type {!Array.<!TreeElement>} */
+    this._highlightedNodes = []
 }
 
 TreeOutline.Events = {
     ElementAttached: "ElementAttached",
     ElementExpanded: "ElementExpanded",
     ElementCollapsed: "ElementCollapsed",
     ElementSelected: "ElementSelected"
 }
 
 TreeOutline.prototype = {
     _createRootElement: function()
     {
         this._rootElement = new TreeElement();
         this._rootElement.treeOutline = this;
         this._rootElement.root = true;
         this._rootElement.selectable = false;
         this._rootElement.expanded = true;
         this._rootElement._childrenListNode.classList.remove("children");
     },
 
     /**
      * @return {!TreeElement}
      */
     rootElement: function()
     {
         return this._rootElement;
     },
 
     /**
+     * @param {boolean} enable
+     */
+    setInteractiveFilterable: function (enable)
+    {
+        if (!enable)
+            this._setCurrentSelectionFilterString("");
+
+        this._interactiveFilterEnabled = enable;
+    },
+
+    /**
+     * @param {string} filterString
+     */
+    _setCurrentSelectionFilterString: function (filterString)
+    {
+        this._currentSelectionFilterString = filterString;
+        this._refreshHighlighting();
+    },
+
+    /**
+     * @param {string} filterString
+     * @return {!RegExp}
+     */
+    _makeFilterRegExpFromString: function (filterString)
+    {
+        return new RegExp(filterString.escapeForRegExp(), "gi")
+    },
+
+    _refreshHighlighting: function ()

[lushnikov, 2016/04/06 00:22:37]

nit: _refreshHighlight:

[allada, 2016/04/09 00:42:48]

Done.

+    {
+        if (!this._rootElement)
+            return;
+
+        var filterRegExp = this._makeFilterRegExpFromString(this._currentSelectionFilterString);

[lushnikov, 2016/04/06 00:22:36]

nit: filterRegex = 

[allada, 2016/04/09 00:42:48]

Done.

+
+        for (var changedNode of this._highlightedNodes)
+            changedNode._revertHighlightChanges();
+
+        this._highlightedNodes = [];
+
+        if (!this._currentSelectionFilterString)
+            return;
+
+        if (this.selectedTreeElement && !this.selectedTreeElement.selectable) {
+            if (!this.selectNext())
+                this.selectPrevious();
+        }
+
+        var node = this._rootElement.firstChild();
+        do {

[lushnikov, 2016/04/06 00:22:36]

nit: no need for do-while; simple while will work

[allada, 2016/04/09 00:42:48]

Done.

+            if (node._applyHighlightFilter(filterRegExp))
+                this._highlightedNodes.push(node);
+            node = node.traverseNextTreeElement(true, null, true);
+        } while(node);
+    },
+
+    /**
+     * @param {!TreeElement} treeElement
+     * @return {boolean}
+     */
+    _checkFilter: function (treeElement)

[lushnikov, 2016/04/06 00:22:36]

Let's move this method into TreeElement; treeElement already has a regex, we
will not need to recreate it here

[allada, 2016/04/09 00:42:48]

Done.

+    {
+        return this._currentSelectionFilterString ? this._makeFilterRegExpFromString(this._currentSelectionFilterString).test(treeElement._titleElement.textContent) : true;
+    },
+
+    _clearFilter: function ()
+    {
+        if (this._interactiveFilterEnabled)
+            this._setCurrentSelectionFilterString("");
+    },
+
+    /**
+     * @param {!Event} event
+     */
+    _handleKeyPressForHighlighting: function (event)
+    {
+        if (!this._interactiveFilterEnabled)
+            return;
+
+        if (event.target !== this._contentElement)
+            return;
+
+        if (!this.selectedTreeElement || event.shiftKey || event.metaKey || event.ctrlKey)
+            return;
+
+        var currentFilterString = this._currentSelectionFilterString;
+
+        switch (event.data) {
+        case "\r":
+        case "\n":
+            break;
+        case " ":
+            if (!currentFilterString)
+                break;
+        default:
+            this._setCurrentSelectionFilterString(currentFilterString + event.data);
+        }
+    },
+
+    /**
      * @return {?TreeElement}
      */
     firstChild: function()
     {
         return this._rootElement.firstChild();
     },
 
     /**
      * @param {!TreeElement} child
      */
@@ skipping 57 matching lines @@
     {
         this._comparator = comparator;
     },
 
     /**
      * @param {boolean} focusable
      */
     setFocusable: function(focusable)
     {
         if (focusable)
-            this._contentElement.setAttribute("tabIndex", 0);
+            this.element.setAttribute("tabIndex", 0);

[lushnikov, 2016/04/06 00:22:36]

this and below seems to be unnecessary

[allada, 2016/04/09 00:42:48]

This is needed to be able to capture keyboard events properly while in this
focused in this frame. To preserve full reverse compatibility to work exactly
how it was, a "nonFocusable" argument was added to the constructor.

         else
-            this._contentElement.removeAttribute("tabIndex");
+            this.element.removeAttribute("tabIndex");
     },
 
     focus: function()
     {
         this._contentElement.focus();
     },
 
     /**
      * @param {!TreeElement} element
      */
@@ skipping 54 matching lines @@
      * @param {!Event} event
      */
     _treeKeyDown: function(event)
     {
         if (event.target !== this._contentElement)
             return;
 
         if (!this.selectedTreeElement || event.shiftKey || event.metaKey || event.ctrlKey)
             return;
 
+        var currentFilterString = this._currentSelectionFilterString;
         var handled = false;
+        var key = event.keyCode;
         var nextSelectedElement;
-        if (event.keyIdentifier === "Up" && !event.altKey) {
-            handled = this.selectPrevious();
-        } else if (event.keyIdentifier === "Down" && !event.altKey) {
-            handled = this.selectNext();
-        } else if (event.keyIdentifier === "Left") {
-            if (this.selectedTreeElement.expanded) {
-                if (event.altKey)
-                    this.selectedTreeElement.collapseRecursively();
-                else
-                    this.selectedTreeElement.collapse();
+
+        switch (key) {
+        case WebInspector.KeyboardShortcut.Keys.Esc.code:
+            if (this._interactiveFilterEnabled) {
+                if (currentFilterString)
+                    handled = true;
+                this._clearFilter();
+            }
+            break;
+        case WebInspector.KeyboardShortcut.Keys.Delete.code:
+            if (this._interactiveFilterEnabled && currentFilterString) {
                 handled = true;
-            } else if (this.selectedTreeElement.parent && !this.selectedTreeElement.parent.root) {
+                this._clearFilter();
+            } else
+                handled = this.selectedTreeElement.ondelete();
+            break;
+        case WebInspector.KeyboardShortcut.Keys.Backspace.code:
+            if (this._interactiveFilterEnabled && currentFilterString) {
                 handled = true;
-                if (this.selectedTreeElement.parent.selectable) {
-                    nextSelectedElement = this.selectedTreeElement.parent;
-                    while (nextSelectedElement && !nextSelectedElement.selectable)
-                        nextSelectedElement = nextSelectedElement.parent;
-                    handled = nextSelectedElement ? true : false;
-                } else if (this.selectedTreeElement.parent)
-                    this.selectedTreeElement.parent.collapse();
+                this._setCurrentSelectionFilterString(currentFilterString.substr(0, currentFilterString.length - 1));
+            } else {
+                handled = this.selectedTreeElement.ondelete();
             }
-        } else if (event.keyIdentifier === "Right") {
+            break;
+        case WebInspector.KeyboardShortcut.Keys.Right.code:
+            if (this._interactiveFilterEnabled)
+                this._clearFilter();
+
             if (!this.selectedTreeElement.revealed()) {
                 this.selectedTreeElement.reveal();
                 handled = true;
             } else if (this.selectedTreeElement._expandable) {
                 handled = true;
                 if (this.selectedTreeElement.expanded) {
                     nextSelectedElement = this.selectedTreeElement.firstChild();
                     while (nextSelectedElement && !nextSelectedElement.selectable)
                         nextSelectedElement = nextSelectedElement.nextSibling;
+

[lushnikov, 2016/04/06 00:22:36]

nit: stray line

[allada, 2016/04/09 00:42:47]

Done.

                     handled = nextSelectedElement ? true : false;
                 } else {
                     if (event.altKey)
                         this.selectedTreeElement.expandRecursively();
                     else
                         this.selectedTreeElement.expand();
                 }
             }
-        } else if (event.keyCode === 8 /* Backspace */ || event.keyCode === 46 /* Delete */)
-            handled = this.selectedTreeElement.ondelete();
-        else if (isEnterKey(event))
-            handled = this.selectedTreeElement.onenter();
-        else if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Space.code)
-            handled = this.selectedTreeElement.onspace();
+            break;
+        case WebInspector.KeyboardShortcut.Keys.Left.code:
+            if (this._interactiveFilterEnabled)
+                this._clearFilter();
+
+            if (this.selectedTreeElement.expanded) {

[lushnikov, 2016/04/06 00:22:36]

Are there any changes in this if-else-if code?

nit: if you put this branch before the "right" code, the "git diff" will be more
descriptive in this case

[allada, 2016/04/09 00:42:48]

Done.

+                if (event.altKey)
+                    this.selectedTreeElement.collapseRecursively();
+                else
+                    this.selectedTreeElement.collapse();
+
+                handled = true;
+            } else if (this.selectedTreeElement.parent && !this.selectedTreeElement.parent.root) {
+                handled = true;
+                if (this.selectedTreeElement.parent.selectable) {
+                    nextSelectedElement = this.selectedTreeElement.parent;
+                    while (nextSelectedElement && !nextSelectedElement.selectable)
+                        nextSelectedElement = nextSelectedElement.parent;
+
+                    handled = nextSelectedElement ? true : false;
+                } else if (this.selectedTreeElement.parent) {
+                    this.selectedTreeElement.parent.collapse();
+                }
+            }
+            break;
+        case WebInspector.KeyboardShortcut.Keys.Down.code:
+            if (!event.altKey)
+                handled = this.selectNext();
+            break;
+        case WebInspector.KeyboardShortcut.Keys.Up.code:
+            if (!event.altKey)
+                handled = this.selectPrevious();
+            break;
+        case WebInspector.KeyboardShortcut.Keys.Space.code:
+            if (!currentFilterString)
+                handled = this.selectedTreeElement.onspace();
+            break;
+        default:
+            if (isEnterKey(event)) {
+                if (this._interactiveFilterEnabled)
+                    this._clearFilter();
+
+                handled = this.selectedTreeElement.onenter();
+            }
+        }
 
         if (nextSelectedElement) {
             nextSelectedElement.reveal();
             nextSelectedElement.select(false, true);
         }
 
         if (handled)
             event.consume(true);
     },
 
@@ skipping 81 matching lines @@
     this._childrenListNode = createElement("ol");
     this._childrenListNode.parentTreeElement = this;
     this._childrenListNode.classList.add("children");
 
     this._hidden = false;
     this._selectable = true;
     this.expanded = false;
     this.selected = false;
     this.setExpandable(expandable || false);
     this._collapsible = true;
+
+    /** @type {!Array.<!Object>} */
+    this._highlightChanges = [];
 }
 
 /** @const */
 TreeElement._ArrowToggleWidth = 10;
 
 TreeElement.prototype = {
     /**
+     * @param {!RegExp} regex
+     * @return {boolean}
+     */
+    _applyHighlightFilter: function (regex) {
+        var textContent = this._listItemNode.textContent;
+        var ranges = [];
+
+        this._revertHighlightChanges();
+
+        var match = regex.exec(textContent);
+        while (match) {
+            ranges.push(new WebInspector.SourceRange(match.index, match[0].length));
+            match = regex.exec(textContent);
+        }
+        if (ranges.length)
+            WebInspector.highlightRangesWithStyleClass(this._listItemNode, ranges, "tree-text-interactive-highlight", this._highlightChanges);
+
+        if (this._highlightChanges.length)

[lushnikov, 2016/04/06 00:22:36]

return !!this._highlightChanges.length;

[allada, 2016/04/09 00:42:47]

Done.

+            return true;
+
+        return false;
+    },
+
+    _revertHighlightChanges: function ()
+    {
+        WebInspector.revertDomChanges(this._highlightChanges);
+        this._highlightChanges = [];
+    },
+
+    /**
      * @param {?TreeElement} ancestor
      * @return {boolean}
      */
     hasAncestor: function(ancestor)
     {
         if (!ancestor)
             return false;
 
         var currentNode = this.parent;
         while (currentNode) {
@@ skipping 199 matching lines @@
                 this.treeOutline._unbindTreeElement(child);
             for (var current = child.firstChild(); this.treeOutline && current; current = current.traverseNextTreeElement(false, child, true))
                 this.treeOutline._unbindTreeElement(current);
             child._detach();
         }
         this._children = [];
     },
 
     get selectable()
     {
-        if (this._hidden)
+        if (this._hidden || !this.treeOutline._checkFilter(this))
             return false;
         return this._selectable;
     },
 
     set selectable(x)
     {
         this._selectable = x;
     },
 
     get listItemElement()
@@ skipping 535 matching lines @@
     isEventWithinDisclosureTriangle: function(event)
     {
         // FIXME: We should not use getComputedStyle(). For that we need to get rid of using ::before for disclosure triangle. (http://webk.it/74446)
         var paddingLeftValue = window.getComputedStyle(this._listItemNode).paddingLeft;
         console.assert(paddingLeftValue.endsWith("px"));
         var computedLeftPadding = parseFloat(paddingLeftValue);
         var left = this._listItemNode.totalOffsetLeft() + computedLeftPadding;
         return event.pageX >= left && event.pageX <= left + TreeElement._ArrowToggleWidth && this._expandable;
     }
 }