Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 18319005: Add broader custom test expectations for blink tests. (Closed)

Created:
7 years, 5 months ago by Michael Achenbach
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Add broader custom test expectations for blink tests to detect crashes. Remove also useless documentation. Most of these tests had some problems (failure, crash or timeout), but which problem exactly cannot be retrieved anymore. We let them rum for a while with a broader test expectation (pass fail slow) and analyse the results. Tests that crash get a crash expectation. Timeouts will get a timeout expectation. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -25 lines) Patch
M tools/blink_tests/TestExpectations View 1 chunk +19 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years, 5 months ago (2013-07-01 11:06:07 UTC) #1
Jakob Kummerow
lgtm
7 years, 5 months ago (2013-07-01 11:07:19 UTC) #2
Michael Achenbach
7 years, 5 months ago (2013-07-01 11:08:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15409 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698