cc/output/software_renderer.h - Issue 1831883002: Use sk_sp-based shader creation APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/software_renderer.h

Issue 1831883002: Use sk_sp-based shader creation APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sprinkle in some std::move and some sk_sp in the API Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/software_renderer.h

diff --git a/cc/output/software_renderer.h b/cc/output/software_renderer.h

index 208b051bfb99754aba5b4b072bec56d0741400c9..19396595406f4403391a774da6a2d09c7ceb09cd 100644

--- a/cc/output/software_renderer.h

+++ b/cc/output/software_renderer.h

@@ -99,7 +99,7 @@ class CC_EXPORT SoftwareRenderer : public DirectRenderer {

const RenderPassDrawQuad* quad,

const gfx::Transform& contents_device_transform) const;

SkBitmap GetBackdropBitmap(const gfx::Rect& bounding_rect) const;

- skia::RefPtr<SkShader> GetBackgroundFilterShader(

+ sk_sp<SkShader> GetBackgroundFilterShader(

const DrawingFrame* frame,

const RenderPassDrawQuad* quad,

SkShader::TileMode content_tile_mode) const;

« no previous file with comments | « no previous file | cc/output/software_renderer.cc » ('j') | cc/output/software_renderer.cc » ('J')