Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 1831873002: Add early out for large textures (Closed)

Created:
4 years, 9 months ago by ericrk
Modified:
4 years, 9 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add getDeferredTextureImageData early out Currently, when dealing with deferred texture image data, we will decode the image even if it will later fail to upload to the GPU due to size constraints. This change adds an early out to our initial decode / sizing logic. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1831873002 Committed: https://skia.googlesource.com/skia/+/c429baf7a28205a19975cfbb60db1b7bfc9c61fa

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/image/SkImage_Gpu.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
ericrk
What do you think about adding something like this?
4 years, 9 months ago (2016-03-24 20:17:39 UTC) #4
bsalomon
On 2016/03/24 20:17:39, ericrk wrote: > What do you think about adding something like this? ...
4 years, 9 months ago (2016-03-24 20:37:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831873002/40001
4 years, 9 months ago (2016-03-24 22:19:41 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 22:35:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c429baf7a28205a19975cfbb60db1b7bfc9c61fa

Powered by Google App Engine
This is Rietveld 408576698