Issue 183183010: Oilpan: Build fix for oilpan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183183010: Oilpan: Build fix for oilpan (Closed)

Created:
6 years, 9 months ago by haraken

Modified:
6 years, 9 months ago

Reviewers:
oilpan-reviews, kouhei (in TOK)

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Oilpan: Build fix for oilpan Some change used PassRefPtrWillBeRawPtr for AnimatableColor which is not yet on the heap. Thus build is broken in oilpan bots. This CL fixes it. TBR=kouhei Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168574

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	Source/core/animation/AnimatableColorTest.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	Source/core/animation/AnimatableDoubleTest.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

haraken

Committed patchset #1 manually as r168574 (tree was closed).

6 years, 9 months ago (2014-03-06 05:48:47 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages