Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 1831783002: [keys] adding fast-path for dict-mode objects with own keys only (Closed)

Created:
4 years, 9 months ago by Camillo Bruni
Modified:
4 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[keys] adding fast-path for dict-mode objects with own keys only BUG= Committed: https://crrev.com/a549d4a7aaa2189cd86fd63ce84623774ff82d6d Cr-Commit-Position: refs/heads/master@{#35138}

Patch Set 1 #

Patch Set 2 : undo change #

Total comments: 1

Patch Set 3 : simplifying simple property test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M src/keys.cc View 1 2 5 chunks +22 lines, -5 lines 0 comments Download
M src/objects.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831783002/20001
4 years, 9 months ago (2016-03-24 10:34:14 UTC) #2
Camillo Bruni
PTAL
4 years, 9 months ago (2016-03-24 10:37:36 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-24 11:02:34 UTC) #6
Toon Verwaest
lgtm https://codereview.chromium.org/1831783002/diff/20001/src/keys.cc File src/keys.cc (right): https://codereview.chromium.org/1831783002/diff/20001/src/keys.cc#newcode409 src/keys.cc:409: return !IsStringWrapperElementsKind(map->elements_kind()) && You can just check for ...
4 years, 8 months ago (2016-03-30 06:51:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831783002/40001
4 years, 8 months ago (2016-03-30 13:22:04 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-30 13:24:02 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 13:25:40 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a549d4a7aaa2189cd86fd63ce84623774ff82d6d
Cr-Commit-Position: refs/heads/master@{#35138}

Powered by Google App Engine
This is Rietveld 408576698