Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1831633002: Make GrGLGetDriverInfo work for null strings. (Closed)

Created:
4 years, 9 months ago by bsalomon
Modified:
4 years, 9 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make GrGLGetDriverInfo work for null strings. The media unit tests in Chromium use a test context that returns nullptr for its vendor/renderer strings. TBR=robertphillips@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1831633002 Committed: https://skia.googlesource.com/skia/+/6383ac0208a77d2f0f8855b2547d3dfda960da76

Patch Set 1 #

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/gpu/gl/GrGLUtil.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831633002/20001
4 years, 9 months ago (2016-03-23 21:44:26 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 21:55:25 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6383ac0208a77d2f0f8855b2547d3dfda960da76

Powered by Google App Engine
This is Rietveld 408576698