Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: src/handles.cc

Issue 18316006: Introduce a handle zapping setting, and enable it by default for release and debug (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/handles.h ('k') | src/handles-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 } 94 }
95 95
96 96
97 void HandleScope::DeleteExtensions(Isolate* isolate) { 97 void HandleScope::DeleteExtensions(Isolate* isolate) {
98 v8::ImplementationUtilities::HandleScopeData* current = 98 v8::ImplementationUtilities::HandleScopeData* current =
99 isolate->handle_scope_data(); 99 isolate->handle_scope_data();
100 isolate->handle_scope_implementer()->DeleteExtensions(current->limit); 100 isolate->handle_scope_implementer()->DeleteExtensions(current->limit);
101 } 101 }
102 102
103 103
104 #ifdef ENABLE_EXTRA_CHECKS 104 #ifdef ENABLE_HANDLE_ZAPPING
105 void HandleScope::ZapRange(Object** start, Object** end) { 105 void HandleScope::ZapRange(Object** start, Object** end) {
106 ASSERT(end - start <= kHandleBlockSize); 106 ASSERT(end - start <= kHandleBlockSize);
107 for (Object** p = start; p != end; p++) { 107 for (Object** p = start; p != end; p++) {
108 *reinterpret_cast<Address*>(p) = v8::internal::kHandleZapValue; 108 *reinterpret_cast<Address*>(p) = v8::internal::kHandleZapValue;
109 } 109 }
110 } 110 }
111 #endif 111 #endif
112 112
113 113
114 Address HandleScope::current_level_address(Isolate* isolate) { 114 Address HandleScope::current_level_address(Isolate* isolate) {
(...skipping 432 matching lines...) Expand 10 before | Expand all | Expand 10 after
547 Handle<InterceptorInfo> interceptor(object->GetNamedInterceptor()); 547 Handle<InterceptorInfo> interceptor(object->GetNamedInterceptor());
548 PropertyCallbackArguments 548 PropertyCallbackArguments
549 args(isolate, interceptor->data(), *receiver, *object); 549 args(isolate, interceptor->data(), *receiver, *object);
550 v8::Handle<v8::Array> result; 550 v8::Handle<v8::Array> result;
551 if (!interceptor->enumerator()->IsUndefined()) { 551 if (!interceptor->enumerator()->IsUndefined()) {
552 v8::NamedPropertyEnumerator enum_fun = 552 v8::NamedPropertyEnumerator enum_fun =
553 v8::ToCData<v8::NamedPropertyEnumerator>(interceptor->enumerator()); 553 v8::ToCData<v8::NamedPropertyEnumerator>(interceptor->enumerator());
554 LOG(isolate, ApiObjectAccess("interceptor-named-enum", *object)); 554 LOG(isolate, ApiObjectAccess("interceptor-named-enum", *object));
555 result = args.Call(enum_fun); 555 result = args.Call(enum_fun);
556 } 556 }
557 #if ENABLE_EXTRA_CHECKS 557 #if ENABLE_HANDLE_ZAPPING
558 CHECK(result.IsEmpty() || v8::Utils::OpenHandle(*result)->IsJSObject()); 558 CHECK(result.IsEmpty() || v8::Utils::OpenHandle(*result)->IsJSObject());
559 #endif 559 #endif
560 return v8::Local<v8::Array>::New(reinterpret_cast<v8::Isolate*>(isolate), 560 return v8::Local<v8::Array>::New(reinterpret_cast<v8::Isolate*>(isolate),
561 result); 561 result);
562 } 562 }
563 563
564 564
565 // Compute the element keys from the interceptor. 565 // Compute the element keys from the interceptor.
566 v8::Handle<v8::Array> GetKeysForIndexedInterceptor(Handle<JSReceiver> receiver, 566 v8::Handle<v8::Array> GetKeysForIndexedInterceptor(Handle<JSReceiver> receiver,
567 Handle<JSObject> object) { 567 Handle<JSObject> object) {
568 Isolate* isolate = receiver->GetIsolate(); 568 Isolate* isolate = receiver->GetIsolate();
569 Handle<InterceptorInfo> interceptor(object->GetIndexedInterceptor()); 569 Handle<InterceptorInfo> interceptor(object->GetIndexedInterceptor());
570 PropertyCallbackArguments 570 PropertyCallbackArguments
571 args(isolate, interceptor->data(), *receiver, *object); 571 args(isolate, interceptor->data(), *receiver, *object);
572 v8::Handle<v8::Array> result; 572 v8::Handle<v8::Array> result;
573 if (!interceptor->enumerator()->IsUndefined()) { 573 if (!interceptor->enumerator()->IsUndefined()) {
574 v8::IndexedPropertyEnumerator enum_fun = 574 v8::IndexedPropertyEnumerator enum_fun =
575 v8::ToCData<v8::IndexedPropertyEnumerator>(interceptor->enumerator()); 575 v8::ToCData<v8::IndexedPropertyEnumerator>(interceptor->enumerator());
576 LOG(isolate, ApiObjectAccess("interceptor-indexed-enum", *object)); 576 LOG(isolate, ApiObjectAccess("interceptor-indexed-enum", *object));
577 result = args.Call(enum_fun); 577 result = args.Call(enum_fun);
578 #if ENABLE_EXTRA_CHECKS 578 #if ENABLE_HANDLE_ZAPPING
579 CHECK(result.IsEmpty() || v8::Utils::OpenHandle(*result)->IsJSObject()); 579 CHECK(result.IsEmpty() || v8::Utils::OpenHandle(*result)->IsJSObject());
580 #endif 580 #endif
581 } 581 }
582 return v8::Local<v8::Array>::New(reinterpret_cast<v8::Isolate*>(isolate), 582 return v8::Local<v8::Array>::New(reinterpret_cast<v8::Isolate*>(isolate),
583 result); 583 result);
584 } 584 }
585 585
586 586
587 Handle<Object> GetScriptNameOrSourceURL(Handle<Script> script) { 587 Handle<Object> GetScriptNameOrSourceURL(Handle<Script> script) {
588 Isolate* isolate = script->GetIsolate(); 588 Isolate* isolate = script->GetIsolate();
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
911 data->next = prev_next_; 911 data->next = prev_next_;
912 data->limit = prev_limit_; 912 data->limit = prev_limit_;
913 #ifdef DEBUG 913 #ifdef DEBUG
914 handles_detached_ = true; 914 handles_detached_ = true;
915 #endif 915 #endif
916 return deferred; 916 return deferred;
917 } 917 }
918 918
919 919
920 } } // namespace v8::internal 920 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/handles.h ('k') | src/handles-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698