Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: src/profile-generator.h

Issue 18316004: Correctly report callstack when current function is FunctionCall builtin (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Removed empty line Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/profile-generator.h
diff --git a/src/profile-generator.h b/src/profile-generator.h
index 38451d11b7579d09866960888bd7191d38d03fb0..7af4df9bc0e6712f181b53ff415aada9292c0987 100644
--- a/src/profile-generator.h
+++ b/src/profile-generator.h
@@ -120,6 +120,9 @@ class CodeEntry {
no_frame_ranges_ = ranges;
}
+ void SetBuiltinId(Builtins::Name id);
+ Builtins::Name builtin_id() const { return builtin_id_; }
+
void CopyData(const CodeEntry& source);
uint32_t GetCallUid() const;
bool IsSameAs(CodeEntry* entry) const;
@@ -128,7 +131,8 @@ class CodeEntry {
static const char* const kEmptyResourceName;
private:
- Logger::LogEventsAndTags tag_;
+ Logger::LogEventsAndTags tag_ : 8;
+ Builtins::Name builtin_id_ : 8;
Jakob Kummerow 2013/07/01 12:16:06 Can you add a STATIC_ASSERT(Builtins::builtin_coun
yurys 2013/07/01 12:50:16 Compilation will fail with a error like the follow
const char* name_prefix_;
const char* name_;
const char* resource_name_;

Powered by Google App Engine
This is Rietveld 408576698