Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: src/profile-generator.h

Issue 18316004: Correctly report callstack when current function is FunctionCall builtin (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Removed empty line Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 INLINE(void set_shared_id(int shared_id)) { shared_id_ = shared_id; } 113 INLINE(void set_shared_id(int shared_id)) { shared_id_ = shared_id; }
114 INLINE(int security_token_id() const) { return security_token_id_; } 114 INLINE(int security_token_id() const) { return security_token_id_; }
115 115
116 INLINE(static bool is_js_function_tag(Logger::LogEventsAndTags tag)); 116 INLINE(static bool is_js_function_tag(Logger::LogEventsAndTags tag));
117 117
118 List<OffsetRange>* no_frame_ranges() const { return no_frame_ranges_; } 118 List<OffsetRange>* no_frame_ranges() const { return no_frame_ranges_; }
119 void set_no_frame_ranges(List<OffsetRange>* ranges) { 119 void set_no_frame_ranges(List<OffsetRange>* ranges) {
120 no_frame_ranges_ = ranges; 120 no_frame_ranges_ = ranges;
121 } 121 }
122 122
123 void SetBuiltinId(Builtins::Name id);
124 Builtins::Name builtin_id() const { return builtin_id_; }
125
123 void CopyData(const CodeEntry& source); 126 void CopyData(const CodeEntry& source);
124 uint32_t GetCallUid() const; 127 uint32_t GetCallUid() const;
125 bool IsSameAs(CodeEntry* entry) const; 128 bool IsSameAs(CodeEntry* entry) const;
126 129
127 static const char* const kEmptyNamePrefix; 130 static const char* const kEmptyNamePrefix;
128 static const char* const kEmptyResourceName; 131 static const char* const kEmptyResourceName;
129 132
130 private: 133 private:
131 Logger::LogEventsAndTags tag_; 134 Logger::LogEventsAndTags tag_ : 8;
135 Builtins::Name builtin_id_ : 8;
Jakob Kummerow 2013/07/01 12:16:06 Can you add a STATIC_ASSERT(Builtins::builtin_coun
yurys 2013/07/01 12:50:16 Compilation will fail with a error like the follow
132 const char* name_prefix_; 136 const char* name_prefix_;
133 const char* name_; 137 const char* name_;
134 const char* resource_name_; 138 const char* resource_name_;
135 int line_number_; 139 int line_number_;
136 int shared_id_; 140 int shared_id_;
137 int security_token_id_; 141 int security_token_id_;
138 List<OffsetRange>* no_frame_ranges_; 142 List<OffsetRange>* no_frame_ranges_;
139 143
140 DISALLOW_COPY_AND_ASSIGN(CodeEntry); 144 DISALLOW_COPY_AND_ASSIGN(CodeEntry);
141 }; 145 };
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 CodeEntry* gc_entry_; 436 CodeEntry* gc_entry_;
433 SampleRateCalculator sample_rate_calc_; 437 SampleRateCalculator sample_rate_calc_;
434 438
435 DISALLOW_COPY_AND_ASSIGN(ProfileGenerator); 439 DISALLOW_COPY_AND_ASSIGN(ProfileGenerator);
436 }; 440 };
437 441
438 442
439 } } // namespace v8::internal 443 } } // namespace v8::internal
440 444
441 #endif // V8_PROFILE_GENERATOR_H_ 445 #endif // V8_PROFILE_GENERATOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698