expose InSummarySource with its summaryPath

expose InSummarySource with its summaryPath

This mechanism is to let DDC in "build mode" easily know which imports come from summaries and which summary file it came from.

R=paulberry@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/09f6f7d7fc46ea4fdeb6952966ac35343515e117

[Jennifer Messerly, 2016-03-23 19:08:10]

jmesserly@google.com changed reviewers:
+ paulberry@google.com, scheglov@google.com

[scheglov, 2016-03-23 19:22:43]

LGTM

https://codereview.chromium.org/1831563002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/package_bundle_reader.dart (right):

https://codereview.chromium.org/1831563002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/package_bundle_reader.dart:131: final Map<String,
String> uriToSummary = <String, String>{};
uriToSummaryPath maybe?

https://codereview.chromium.org/1831563002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/package_bundle_reader.dart:193: * The summary file
where this source file was defined.
"source file" -> "source"

[Jennifer Messerly, 2016-03-23 19:25:57]

thanks!

https://codereview.chromium.org/1831563002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/package_bundle_reader.dart (right):

https://codereview.chromium.org/1831563002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/package_bundle_reader.dart:131: final Map<String,
String> uriToSummary = <String, String>{};
On 2016/03/23 19:22:42, scheglov wrote:
> uriToSummaryPath maybe?

good idea! done

https://codereview.chromium.org/1831563002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/package_bundle_reader.dart:193: * The summary file
where this source file was defined.
On 2016/03/23 19:22:42, scheglov wrote:
> "source file" -> "source"

Done.

[Paul Berry, 2016-03-23 20:30:50]

lgtm

[Jennifer Messerly, 2016-03-24 00:34:27]

Description was changed from

==========
expose InSummarySource with its summaryPath

This mechanism is to let DDC in "build mode" easily know which imports come from
summaries and which summary file it came from.
==========

to

==========
expose InSummarySource with its summaryPath

This mechanism is to let DDC in "build mode" easily know which imports come from
summaries and which summary file it came from.

R=paulberry@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/09f6f7d7fc46ea4fdeb6952966ac35343515e117
==========

[Jennifer Messerly, 2016-03-24 00:34:28]

Committed patchset #3 (id:40001) manually as
09f6f7d7fc46ea4fdeb6952966ac35343515e117 (presubmit successful).