Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1831533002: Fix broken dartium build due to invalid dependencies when dart_io_support=0 (Closed)

Created:
4 years, 9 months ago by Jacob
Modified:
4 years, 9 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix broken dartium build due to invalid dependencies when dart_io_support=0 BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/5c8de46a7df559abfc4b310f74499900552f5184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/bin/bin.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
4 years, 9 months ago (2016-03-23 17:35:40 UTC) #2
zra
lgtm
4 years, 9 months ago (2016-03-23 17:38:16 UTC) #3
Jacob
4 years, 9 months ago (2016-03-23 17:40:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5c8de46a7df559abfc4b310f74499900552f5184 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698