Make shared worker aware kEnableSharedWorkerMemoryInfo switch

Make shared worker aware kEnableSharedWorkerMemoryInfo switch

This CL works for enabling performance.memory in shared worker, it introduce switch kEnableSharedWorkerMemoryInfo to shared worker process,then pass to Blink via Blink's runtime enabled flags.

BUG=326370
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263184

[Pan, 2014-02-27 14:33:18]

Hi @kinuko

I didn't find a good way to pass chrome only switch "kEnableMemoryInfo" to
content layer.
While, IMHO, it would be better to live as a content::switch, since the
"performance.memory" currently lives in blink API.

thanks
Pan

[kinuko, 2014-02-28 05:26:11]

https://codereview.chromium.org/183153002/diff/1/content/public/common/conten...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/183153002/diff/1/content/public/common/conten...
content/public/common/content_switches.cc:484: const char kEnableMemoryInfo[]   
          = "enable-memory-info";
If you think kEnableMemoryInfo switch should live in content this looks ok to
me. (Otherwise we could add some public content method and override it in
chrome)

https://codereview.chromium.org/183153002/diff/1/content/worker/websharedwork...
File content/worker/websharedworkerclient_proxy.cc (right):

https://codereview.chromium.org/183153002/diff/1/content/worker/websharedwork...
content/worker/websharedworkerclient_proxy.cc:90: }
As I commented on the other thread, can we avoid adding settings-specific method
here?

[Pan, 2014-03-06 09:22:24]

On 2014/02/28 05:26:11, kinuko wrote:
>
https://codereview.chromium.org/183153002/diff/1/content/public/common/conten...
> File content/public/common/content_switches.cc (right):
> 
>
https://codereview.chromium.org/183153002/diff/1/content/public/common/conten...
> content/public/common/content_switches.cc:484: const char kEnableMemoryInfo[] 
 
>           = "enable-memory-info";
> If you think kEnableMemoryInfo switch should live in content this looks ok to
> me. (Otherwise we could add some public content method and override it in
> chrome)
> 
>
https://codereview.chromium.org/183153002/diff/1/content/worker/websharedwork...
> File content/worker/websharedworkerclient_proxy.cc (right):
> 
>
https://codereview.chromium.org/183153002/diff/1/content/worker/websharedwork...
> content/worker/websharedworkerclient_proxy.cc:90: }
> As I commented on the other thread, can we avoid adding settings-specific
method
> here?

update according to https://codereview.chromium.org/106353005/, 
thanks
Pan

[Pan, 2014-04-08 12:48:59]

Hi @jam

This CL works for CR issue
http://code.google.com/p/chromium/issues/detail?id=326370, to access
performance.memory in shared workers.
Major Blink implementation is in https://codereview.chromium.org/106353005/.
To provide detailed heap info when switch is on, we have to aware the switch and
pass that info through shared worker, 
abarth suggest us take steps to achieve the goal:
1st step is the change of Blink public API,
see@http://src.chromium.org/viewvc/blink?view=revision&revision=170417
This CL is the 2nd step, call the public API and pass the switch info from
chromium to Blink.
Please review

thanks
Pan

[jam, 2014-04-10 14:39:45]

lgtm with comments

https://codereview.chromium.org/183153002/diff/100001/content/public/common/c...
File content/public/common/content_switches.h (right):

https://codereview.chromium.org/183153002/diff/100001/content/public/common/c...
content/public/common/content_switches.h:147: CONTENT_EXPORT extern const char
kEnableMemoryInfo[];
since this is for workers only, you should make it clear in the flag name. i.e.
kEnableSharedWorkerMemoryInfo

nit: don't need export

https://codereview.chromium.org/183153002/diff/100001/content/worker/webshare...
File content/worker/websharedworker_stub.cc (right):

https://codereview.chromium.org/183153002/diff/100001/content/worker/webshare...
content/worker/websharedworker_stub.cc:49:
blink::WebRuntimeFeatures::enablePreciseMemoryInfo(CommandLine::
nit: this wrapping looks odd. put CommandLine:: at the start of the next line,
it'll still fit.

[Pan, 2014-04-11 01:52:13]

https://codereview.chromium.org/183153002/diff/100001/content/public/common/c...
File content/public/common/content_switches.h (right):

https://codereview.chromium.org/183153002/diff/100001/content/public/common/c...
content/public/common/content_switches.h:147: CONTENT_EXPORT extern const char
kEnableMemoryInfo[];
On 2014/04/10 14:39:45, jam wrote:
> since this is for workers only, you should make it clear in the flag name.
i.e.
> kEnableSharedWorkerMemoryInfo
> 
> nit: don't need export
thanks, done.

https://codereview.chromium.org/183153002/diff/100001/content/worker/webshare...
File content/worker/websharedworker_stub.cc (right):

https://codereview.chromium.org/183153002/diff/100001/content/worker/webshare...
content/worker/websharedworker_stub.cc:49:
blink::WebRuntimeFeatures::enablePreciseMemoryInfo(CommandLine::
On 2014/04/10 14:39:45, jam wrote:
> nit: this wrapping looks odd. put CommandLine:: at the start of the next line,
> it'll still fit.
thanks, done

[Pan, 2014-04-11 01:53:19]

The CQ bit was checked by pan.deng@intel.com

[commit-bot: I haz the power, 2014-04-11 01:54:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pan.deng@intel.com/183153002/120001

[commit-bot: I haz the power, 2014-04-11 01:54:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-11 01:54:45]

Failed to apply patch for content/public/common/content_switches.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/public/common/content_switches.h
  Hunk #1 FAILED at 155.
  1 out of 1 hunk FAILED -- saving rejects to file
content/public/common/content_switches.h.rej

Patch:       content/public/common/content_switches.h
Index: content/public/common/content_switches.h
diff --git a/content/public/common/content_switches.h
b/content/public/common/content_switches.h
index
6d0b73c0454d83c18307bd13804d634b14614f44..6f6939c4444659144118dcb5c05fdf62cfd74b53
100644
--- a/content/public/common/content_switches.h
+++ b/content/public/common/content_switches.h
@@ -155,6 +155,7 @@ CONTENT_EXPORT extern const char
kEnablePrivilegedWebGLExtensions[];
 CONTENT_EXPORT extern const char kEnableRegionBasedColumns[];
 CONTENT_EXPORT extern const char kEnableRepaintAfterLayout[];
 CONTENT_EXPORT extern const char kEnableSandboxLogging[];
+extern const char kEnableSharedWorkerMemoryInfo[];
 extern const char kEnableSkiaBenchmarking[];
 CONTENT_EXPORT extern const char kEnableSmoothScrolling[];
 CONTENT_EXPORT extern const char kEnableSoftwareCompositing[];

[Pan, 2014-04-11 03:37:11]

The CQ bit was checked by pan.deng@intel.com

[commit-bot: I haz the power, 2014-04-11 03:39:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pan.deng@intel.com/183153002/140001

[commit-bot: I haz the power, 2014-04-11 07:55:35]

Change committed as 263184