Add a bitcode parser constructor for parallel parsing.

Add a bitcode parser constructor for parallel parsing.

Allows the caller of the constructor to provide the bitstream cursor to
use, rather than inheriting from the enclosing parser. This allows each
parallel parse (of subblocks) to create thier own bitcode cursor.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4363
R=jpp@chromium.org, stichnot@chromium.org

Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/ad73601fb508e3754169cf2fd3e3eefc813723a2

[Karl, 2016-03-23 20:38:02]

Description was changed from

==========
Add a bitcode parser constructor for parallel parsing.

Allows the caller of the constructor to provide the bitstream cursor to
use, rather than inheriting from the enclosing parser. This allows each
parallel parse (of subblocks) to create thier own bitcode cursor.

Add bitcode parser constructor with explicit cursor argument.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4363
==========

to

==========
Add a bitcode parser constructor for parallel parsing.

Allows the caller of the constructor to provide the bitstream cursor to
use, rather than inheriting from the enclosing parser. This allows each
parallel parse (of subblocks) to create thier own bitcode cursor.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4363
==========

[Karl, 2016-03-23 20:38:02]

kschimpf@google.com changed reviewers:
+ dschuff@chromium.org, jpp@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2016-03-23 21:20:30]

https://codereview.chromium.org/1831493003/diff/1/include/llvm/Bitcode/NaCl/N...
File include/llvm/Bitcode/NaCl/NaClBitcodeParser.h (right):

https://codereview.chromium.org/1831493003/diff/1/include/llvm/Bitcode/NaCl/N...
include/llvm/Bitcode/NaCl/NaClBitcodeParser.h:612: // Same as above, but use the
given bitstrem cursor (instead of inheriting
bitstream

https://codereview.chromium.org/1831493003/diff/1/include/llvm/Bitcode/NaCl/N...
include/llvm/Bitcode/NaCl/NaClBitcodeParser.h:612: // Same as above, but use the
given bitstrem cursor (instead of inheriting
maybe s/given/supplied/ ?

https://codereview.chromium.org/1831493003/diff/1/include/llvm/Bitcode/NaCl/N...
include/llvm/Bitcode/NaCl/NaClBitcodeParser.h:617: NaClBitstreamCursor &Cursor)
I'm not familiar with this set of data structures, so I'd just ask you to take a
second look at this and make sure passing Cursor by non-const ref is the right
thing here.

https://codereview.chromium.org/1831493003/diff/1/include/llvm/Bitcode/NaCl/N...
include/llvm/Bitcode/NaCl/NaClBitcodeParser.h:621: Listener(0),
Listener(nullptr)

[John, 2016-03-24 13:08:16]

lgtm

https://codereview.chromium.org/1831493003/diff/1/include/llvm/Bitcode/NaCl/N...
File include/llvm/Bitcode/NaCl/NaClBitcodeParser.h (right):

https://codereview.chromium.org/1831493003/diff/1/include/llvm/Bitcode/NaCl/N...
include/llvm/Bitcode/NaCl/NaClBitcodeParser.h:617: NaClBitstreamCursor &Cursor)
On 2016/03/23 21:20:29, stichnot wrote:
> I'm not familiar with this set of data structures, so I'd just ask you to take
a
> second look at this and make sure passing Cursor by non-const ref is the right
> thing here.

It is the right thing as NaClBitcodeData holds a non-const reference to the
cursor -- I just which it held a pointer instead...

[Jim Stichnoth, 2016-03-24 13:09:19]

https://codereview.chromium.org/1831493003/diff/1/include/llvm/Bitcode/NaCl/N...
File include/llvm/Bitcode/NaCl/NaClBitcodeParser.h (right):

https://codereview.chromium.org/1831493003/diff/1/include/llvm/Bitcode/NaCl/N...
include/llvm/Bitcode/NaCl/NaClBitcodeParser.h:617: NaClBitstreamCursor &Cursor)
On 2016/03/24 13:08:16, John wrote:
> On 2016/03/23 21:20:29, stichnot wrote:
> > I'm not familiar with this set of data structures, so I'd just ask you to
take
> a
> > second look at this and make sure passing Cursor by non-const ref is the
right
> > thing here.
> 
> It is the right thing as NaClBitcodeData holds a non-const reference to the
> cursor -- I just which it held a pointer instead...

OK - otherwise LGTM.

[Karl, 2016-03-24 16:15:54]

Description was changed from

==========
Add a bitcode parser constructor for parallel parsing.

Allows the caller of the constructor to provide the bitstream cursor to
use, rather than inheriting from the enclosing parser. This allows each
parallel parse (of subblocks) to create thier own bitcode cursor.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4363
==========

to

==========
Add a bitcode parser constructor for parallel parsing.

Allows the caller of the constructor to provide the bitstream cursor to
use, rather than inheriting from the enclosing parser. This allows each
parallel parse (of subblocks) to create thier own bitcode cursor.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4363
R=jpp@chromium.org, stichnot@chromium.org

Committed:
https://chromium.googlesource.com/native_client/pnacl-llvm/+/ad73601fb508e375...
==========

[Karl, 2016-03-24 16:15:58]

Committed patchset #2 (id:20001) manually as
ad73601fb508e3754169cf2fd3e3eefc813723a2 (presubmit successful).

[Karl, 2016-03-24 19:29:09]

https://codereview.chromium.org/1831493003/diff/1/include/llvm/Bitcode/NaCl/N...
File include/llvm/Bitcode/NaCl/NaClBitcodeParser.h (right):

https://codereview.chromium.org/1831493003/diff/1/include/llvm/Bitcode/NaCl/N...
include/llvm/Bitcode/NaCl/NaClBitcodeParser.h:612: // Same as above, but use the
given bitstrem cursor (instead of inheriting
On 2016/03/23 21:20:29, stichnot wrote:
> bitstream

Done.

https://codereview.chromium.org/1831493003/diff/1/include/llvm/Bitcode/NaCl/N...
include/llvm/Bitcode/NaCl/NaClBitcodeParser.h:617: NaClBitstreamCursor &Cursor)
On 2016/03/23 21:20:29, stichnot wrote:
> I'm not familiar with this set of data structures, so I'd just ask you to take
a
> second look at this and make sure passing Cursor by non-const ref is the right
> thing here.

Acknowledged.

https://codereview.chromium.org/1831493003/diff/1/include/llvm/Bitcode/NaCl/N...
include/llvm/Bitcode/NaCl/NaClBitcodeParser.h:621: Listener(0),
On 2016/03/23 21:20:29, stichnot wrote:
> Listener(nullptr)

Actually, it should have been:

   Listener(EnclosingParser->Listener).

Changing.