Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1831473003: 🌕 Update binary_size/README.txt to have GN args rather than GYP_DEFINES (Closed)

Created:
4 years, 9 months ago by agrieve
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update binary_size/README.txt to have GN args rather than GYP_DEFINES BUG=none Committed: https://crrev.com/0f90ad8a2751b55f1193112652705d21bbb2a8d0 Cr-Commit-Position: refs/heads/master@{#383066}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M tools/binary_size/README.txt View 1 2 chunks +8 lines, -9 lines 0 comments Download

Depends on Patchset:

Issue 1543003005 Patch 1

Messages

Total messages: 8 (3 generated)
agrieve
4 years, 9 months ago (2016-03-23 18:30:02 UTC) #2
Primiano Tucci (use gerrit)
LGTM thanks for updateing docs
4 years, 9 months ago (2016-03-24 15:17:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831473003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831473003/20001
4 years, 9 months ago (2016-03-24 15:17:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-24 15:51:57 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 15:53:34 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0f90ad8a2751b55f1193112652705d21bbb2a8d0
Cr-Commit-Position: refs/heads/master@{#383066}

Powered by Google App Engine
This is Rietveld 408576698