Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1831463002: Add layout test suppression for upcoming Skia DEPS roll (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add layout test suppression for upcoming Skia DEPS roll The Skia CL https://codereview.chromium.org/1784863003/ (Switch SkDropShaderImageFilter over to new onFilterImage interface) imperceptibly changed the following layout tests: svg/filters/feDropShadow.svg [ Failure ] BUG=597276 Committed: https://crrev.com/20984cd5302d53bc545c377a8581b77d2466e80a Cr-Commit-Position: refs/heads/master@{#382872}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
robertphillips
4 years, 9 months ago (2016-03-23 14:45:04 UTC) #3
f(malita)
lgtm https://codereview.chromium.org/1831463002/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1831463002/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode213 third_party/WebKit/LayoutTests/TestExpectations:213: crbug.com/597276 svg/filters/feDropShadow.svg [ Failure ] Nit: for temporary ...
4 years, 9 months ago (2016-03-23 14:47:08 UTC) #4
robertphillips
https://codereview.chromium.org/1831463002/diff/1/third_party/WebKit/LayoutTests/TestExpectations File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1831463002/diff/1/third_party/WebKit/LayoutTests/TestExpectations#newcode213 third_party/WebKit/LayoutTests/TestExpectations:213: crbug.com/597276 svg/filters/feDropShadow.svg [ Failure ] On 2016/03/23 14:47:08, f(malita) ...
4 years, 9 months ago (2016-03-23 14:49:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831463002/20001
4 years, 9 months ago (2016-03-23 14:49:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 17:32:08 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 17:33:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20984cd5302d53bc545c377a8581b77d2466e80a
Cr-Commit-Position: refs/heads/master@{#382872}

Powered by Google App Engine
This is Rietveld 408576698