Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 183143002: Remove SVGAnimatedType (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, fs, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, dino_apple.com, pdr., Eric Willigers
Visibility:
Public.

Description

Remove SVGAnimatedType With the transition to the new SVGProperty hierarchy complete, SVGAnimatedType is nothing but a wrapper holding a reference to a NewSVGPropertyBase. By unwrapping this reference in SVGAnimateElement, and modifying the SVGAnimatedTypeAnimator interface to pass NewSVGPropertyBase references instead it becomes possible to remove SVGAnimatedType without much hassle. The SVGAnimatedTypeAnimator interfaces are to a large degree left unchanged, with the exceptions being: * addAnimatedTypes is folded in favor just using the add() method on NewSVGPropertyBase. * resetAnimValToBaseVal returns the value instead of setting it through an out-parameter. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168150

Patch Set 1 #

Patch Set 2 : Drop methods from SVGAnimatedTypeAnimator. #

Patch Set 3 : Missed one rename. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -430 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGAnimateElement.h View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.cpp View 1 2 11 chunks +24 lines, -25 lines 0 comments Download
M Source/core/svg/SVGAnimatedNewPropertyAnimator.h View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/svg/SVGAnimatedNewPropertyAnimator.cpp View 5 chunks +11 lines, -16 lines 0 comments Download
D Source/core/svg/SVGAnimatedType.h View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/core/svg/SVGAnimatedType.cpp View 1 chunk +0 lines, -156 lines 0 comments Download
M Source/core/svg/SVGAnimatedTypeAnimator.h View 1 3 chunks +7 lines, -159 lines 0 comments Download
M Source/core/svg/SVGAnimatedTypeAnimator.cpp View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
fs
6 years, 9 months ago (2014-02-27 16:12:10 UTC) #1
kouhei (in TOK)
lgtm Thanks a lot for participating in cleanup!
6 years, 9 months ago (2014-02-27 23:01:07 UTC) #2
rwlbuis
lgtm
6 years, 9 months ago (2014-02-28 16:44:51 UTC) #3
rwlbuis
lgtm
6 years, 9 months ago (2014-02-28 16:44:53 UTC) #4
fs
The CQ bit was checked by fs@opera.com
6 years, 9 months ago (2014-02-28 17:12:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/183143002/40001
6 years, 9 months ago (2014-02-28 17:12:16 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 18:30:10 UTC) #7
Message was sent while issue was closed.
Change committed as 168150

Powered by Google App Engine
This is Rietveld 408576698