Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: content/renderer/render_view_impl.cc

Issue 1831423003: Audit test code callsites that need an explicit lifecycle update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean up. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_view_impl.h" 5 #include "content/renderer/render_view_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 1214 matching lines...) Expand 10 before | Expand all | Expand 10 after
1225 // Get rendered text from WebLocalFrame. 1225 // Get rendered text from WebLocalFrame.
1226 // TODO: Currently IPC truncates any data that has a 1226 // TODO: Currently IPC truncates any data that has a
1227 // size > kMaximumMessageSize. May be split the text into smaller chunks and 1227 // size > kMaximumMessageSize. May be split the text into smaller chunks and
1228 // send back using multiple IPC. See http://crbug.com/393444. 1228 // send back using multiple IPC. See http://crbug.com/393444.
1229 static const size_t kMaximumMessageSize = 8 * 1024 * 1024; 1229 static const size_t kMaximumMessageSize = 8 * 1024 * 1024;
1230 // TODO(dglazkov): Using this API is wrong. It's not OOPIF-compatible and 1230 // TODO(dglazkov): Using this API is wrong. It's not OOPIF-compatible and
1231 // sends text in the wrong order. See http://crbug.com/584798. 1231 // sends text in the wrong order. See http://crbug.com/584798.
1232 // TODO(dglazkov): WebFrameContentDumper should only be used for 1232 // TODO(dglazkov): WebFrameContentDumper should only be used for
1233 // testing purposes. See http://crbug.com/585164. 1233 // testing purposes. See http://crbug.com/585164.
1234 std::string text = 1234 std::string text =
1235 WebFrameContentDumper::dumpFrameTreeAsText( 1235 WebFrameContentDumper::deprecatedDumpFrameTreeAsText(
1236 webview()->mainFrame()->toWebLocalFrame(), kMaximumMessageSize) 1236 webview()->mainFrame()->toWebLocalFrame(), kMaximumMessageSize)
1237 .utf8(); 1237 .utf8();
1238 1238
1239 Send(new ViewMsg_GetRenderedTextCompleted(GetRoutingID(), text)); 1239 Send(new ViewMsg_GetRenderedTextCompleted(GetRoutingID(), text));
1240 } 1240 }
1241 1241
1242 void RenderViewImpl::StartPluginIme() { 1242 void RenderViewImpl::StartPluginIme() {
1243 IPC::Message* msg = new ViewHostMsg_StartPluginIme(GetRoutingID()); 1243 IPC::Message* msg = new ViewHostMsg_StartPluginIme(GetRoutingID());
1244 // This message can be sent during event-handling, and needs to be delivered 1244 // This message can be sent during event-handling, and needs to be delivered
1245 // within that context. 1245 // within that context.
(...skipping 2195 matching lines...) Expand 10 before | Expand all | Expand 10 after
3441 if (IsUseZoomForDSFEnabled()) { 3441 if (IsUseZoomForDSFEnabled()) {
3442 webview()->setZoomFactorForDeviceScaleFactor(device_scale_factor_); 3442 webview()->setZoomFactorForDeviceScaleFactor(device_scale_factor_);
3443 } else { 3443 } else {
3444 webview()->setDeviceScaleFactor(device_scale_factor_); 3444 webview()->setDeviceScaleFactor(device_scale_factor_);
3445 } 3445 }
3446 webview()->settings()->setPreferCompositingToLCDTextEnabled( 3446 webview()->settings()->setPreferCompositingToLCDTextEnabled(
3447 PreferCompositingToLCDText(compositor_deps_, device_scale_factor_)); 3447 PreferCompositingToLCDText(compositor_deps_, device_scale_factor_));
3448 } 3448 }
3449 3449
3450 } // namespace content 3450 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/render_view_browsertest_mac.mm ('k') | third_party/WebKit/Source/web/WebFrameContentDumper.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698