Enable DMP for system Chromium WebView on Android

third_party/tcmalloc/chromium/src/base/linux_syscall_support.h

 /* Copyright (c) 2005-2008, Google Inc.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 139 matching lines @@
 #include <stdarg.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <string.h>
 #include <sys/ptrace.h>
 #include <sys/resource.h>
 #include <sys/time.h>
 #include <sys/types.h>
 #if defined(__ANDROID__)
 #include <sys/syscall.h>
-#include <sys/linux-syscalls.h>
+#ifndef ANDROID_NON_SDK_BUILD
+# include <sys/linux-syscalls.h>

[willchan no longer on Chromium, 2013/07/18 16:20:26]

Is this a typo? Why is there a space between '#' and 'include'?

[mnaganov (inactive), 2013/07/18 16:24:37]

It's indentation within preprocessor directives. Examples:
https://code.google.com/p/chromium/codesearch#search/&q=%22%23%20include%22&s...

Probably looks inconsistent with the rest. I can remove it.

[mnaganov (inactive), 2013/07/18 16:26:02]

Sorry, the link doesn't work. Just search for "# include" (with quotes) in
codesearch.

[willchan no longer on Chromium, 2013/07/18 16:35:21]

I learned some new things today :) Thanks! Never heard of it and lo and behold
it's actually discussed in the style guide:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Prepro....
The style guide says it's OK.

That said, my preference would be not to use this because I think it's not well
known, and confusing to people. I've never seen this before, and I don't think
it's used much if at all in core Chromium code (everything in cs.chromium.org
seems to indicate it's in chromium/usr/include/... which I don't consider core).

If you feel strongly, then I'm willing to let it in. But my preference is not to
do so. Up to you. Thanks.

LGTM.

+#endif
 #else
 #include <syscall.h>
 #endif
 #include <unistd.h>
 #include <linux/unistd.h>
 #include <endian.h>
 
 #ifdef __mips__
 /* Include definitions of the ABI currently in use.                          */
 #include <sgidefs.h>
@@ skipping 2098 matching lines @@
     return rc;
   }
 #endif
 
 #if defined(__cplusplus) && !defined(SYS_CPLUSPLUS)
 }
 #endif
 
 #endif
 #endif