Issue 183133002: Rollback of r19549 in 3.24 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183133002: Rollback of r19549 in 3.24 branch. (Closed)

Created:
6 years, 9 months ago by Igor Sheludko

Modified:
6 years, 9 months ago

Reviewers:
Hannes Payer (out of office), Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.24

Visibility:
Public.

Rollback of r19549 in 3.24 branch. Fix for failing asserts in HBoundsCheck code generation on x64: index register should be zero extended. BUG=345820 LOG=N R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19580

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -22 lines)			Patch
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/disasm-x64.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/x64/lithium-gap-resolver-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	test/mjsunit/regress/regress-crbug-345820.js	View	1 chunk	+0 lines, -18 lines	0 comments	Download

Total messages: 3 (0 generated)

Igor Sheludko

6 years, 9 months ago (2014-02-27 14:58:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19580 (tree was closed).