tests/RecordOptsTest.cpp - Issue 1831323003: Swap SkPictureImageFilter's factories over to smart pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/RecordOptsTest.cpp

Issue 1831323003: Swap SkPictureImageFilter's factories over to smart pointers (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix sk_sp bug Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/RecordOptsTest.cpp

diff --git a/tests/RecordOptsTest.cpp b/tests/RecordOptsTest.cpp

index 77eb76bc0288e6715ef754fa2a906a296962958b..242712da3bb3194be49888c02147d9e9807cb8a7 100644

--- a/tests/RecordOptsTest.cpp

+++ b/tests/RecordOptsTest.cpp

@@ -239,7 +239,7 @@ DEF_TEST(RecordOpts_MergeSvgOpacityAndFilterLayers, r) {

canvas->drawRect(SkRect::MakeWH(SkIntToScalar(50), SkIntToScalar(50)), shapePaint);

shape = recorder.finishRecordingAsPicture();

}

- translucentFilterLayerPaint.setImageFilter(SkPictureImageFilter::Create(shape.get()))->unref();

+ translucentFilterLayerPaint.setImageFilter(SkPictureImageFilter::Make(shape));

int index = 0;

« no previous file with comments | « tests/ImageFilterTest.cpp ('k') | no next file » | no next file with comments »