samplecode/SampleFilterFuzz.cpp - Issue 1831323003: Swap SkPictureImageFilter's factories over to smart pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samplecode/SampleFilterFuzz.cpp

Issue 1831323003: Swap SkPictureImageFilter's factories over to smart pointers (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix sk_sp bug Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samplecode/SampleFilterFuzz.cpp

diff --git a/samplecode/SampleFilterFuzz.cpp b/samplecode/SampleFilterFuzz.cpp

index dd72d1237c6a04c9fc0d7fc494da860eafe650d7..0602e2bcbbf926b82884b4f744c472c6e45493ba 100644

--- a/samplecode/SampleFilterFuzz.cpp

+++ b/samplecode/SampleFilterFuzz.cpp

@@ -701,7 +701,7 @@ static SkImageFilter* make_image_filter(bool canBeNull) {

&factory, 0);

drawSomething(recordingCanvas);

sk_sp<SkPicture> pict(recorder.finishRecordingAsPicture());

- filter = SkPictureImageFilter::Create(pict.get(), make_rect());

+ filter = SkPictureImageFilter::Make(pict, make_rect()).release();

}

break;

case PAINT:

« no previous file with comments | « include/effects/SkPictureImageFilter.h ('k') | src/effects/SkPictureImageFilter.cpp » ('j') | no next file with comments »