gm/recordopts.cpp - Issue 1831323003: Swap SkPictureImageFilter's factories over to smart pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/recordopts.cpp

Issue 1831323003: Swap SkPictureImageFilter's factories over to smart pointers (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix sk_sp bug Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/recordopts.cpp

diff --git a/gm/recordopts.cpp b/gm/recordopts.cpp

index bac6d8858ce2ca8a8a9cf208d20c29a2ecdf865c..3c44f4ac272697b0156bb2b3af8e3e029eb27ec5 100644

--- a/gm/recordopts.cpp

+++ b/gm/recordopts.cpp

@@ -117,7 +117,7 @@ static void draw_svg_opacity_and_filter_layer_sequence(SkCanvas* canvas, SkColor

canvas->save();

canvas->clipRect(targetRect);

SkPaint drawPaint;

- drawPaint.setImageFilter(SkPictureImageFilter::Create(shape.get()))->unref();

+ drawPaint.setImageFilter(SkPictureImageFilter::Make(shape));

installDetector(&drawPaint);

canvas->saveLayer(&targetRect, &drawPaint);

canvas->restore();

« no previous file with comments | « gm/pictureimagefilter.cpp ('k') | include/effects/SkPictureImageFilter.h » ('j') | no next file with comments »