Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 18313007: Change DataView accessors behavior for insufficient args. (Closed)

Created:
7 years, 5 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Change DataView accessors behavior for insufficient args. ES6 spec for DataView is not fully finished, but Blink, WebKit and Firefox agree in that for DataView use of getters/setters with no arguments should result in exceptions, while undefined offset argument is the same as zero. R=bmeurer@chromium.org, rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15607

Patch Set 1 #

Patch Set 2 : Fixed bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -8 lines) Patch
M src/typedarray.js View 1 16 chunks +46 lines, -6 lines 0 comments Download
M test/mjsunit/harmony/dataview-accessors.js View 1 9 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dmitry Lomov (no reviews)
PTAL
7 years, 5 months ago (2013-07-10 13:40:29 UTC) #1
Dmitry Lomov (no reviews)
Found a bug with condition on %_ArgumentLength(). Fixed and made sure tests catch it.
7 years, 5 months ago (2013-07-10 14:23:06 UTC) #2
Dmitry Lomov (no reviews)
7 years, 5 months ago (2013-07-10 14:23:12 UTC) #3
Benedikt Meurer
LGTM, but I'm not yet all that familiar with this stuff, so maybe better wait ...
7 years, 5 months ago (2013-07-10 14:34:56 UTC) #4
rossberg
lgtm
7 years, 5 months ago (2013-07-10 14:58:33 UTC) #5
Dmitry Lomov (no reviews)
7 years, 5 months ago (2013-07-10 16:19:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r15607 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698