Issue 18313: Fix disassembling of set instructions....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18313: Fix disassembling of set instructions.... (Closed)

Created:
11 years, 11 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Description

Fix disassembling of set instructions. I don't really like the pointer to member thing, but it was the best I could think of to not replicate the code. We could use the NameOfByteRegister and PrintRightByteOperand in a number of other places (such as test_b, but I will leave that for another changelist). Committed: http://code.google.com/p/v8/source/detail?r=1105

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -19 lines)			Patch
M	src/disasm.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/disasm-arm.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/disasm-ia32.cc	View	12 chunks	+56 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages