Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1831243002: MD Settings: polish fixes for bettes@ on appearance page (Closed)

Created:
4 years, 9 months ago by Dan Beam
Modified:
4 years, 9 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: polish fixes for bettes@ on appearance page 1) remove "open in app" buttons 2) fix some two line control icons R=dschuyler@chromium.org BUG=597871 Committed: https://crrev.com/66cb92537d00d4ffdafd72a4c2a39d01fc1b5598 Cr-Commit-Position: refs/heads/master@{#383384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dan Beam
4 years, 9 months ago (2016-03-25 02:07:43 UTC) #1
dschuyler
lgtm
4 years, 9 months ago (2016-03-25 22:07:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831243002/1
4 years, 9 months ago (2016-03-25 22:19:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 22:27:00 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 22:28:32 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/66cb92537d00d4ffdafd72a4c2a39d01fc1b5598
Cr-Commit-Position: refs/heads/master@{#383384}

Powered by Google App Engine
This is Rietveld 408576698