Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 1831233004: Remove unused code from RenderFrameProxyHost. (Closed)

Created:
4 years, 9 months ago by nasko
Modified:
4 years, 9 months ago
Reviewers:
alexmos
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused code from RenderFrameProxyHost. Since swapped out state on RenderFrameHost has been removed, there is no longer usage of RenderFrameProxyHost transfering ownership and the code can safely be removed. BUG=357747 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/a949e39cbe5f6ef8bad2e9221af8ee1152be2419 Cr-Commit-Position: refs/heads/master@{#383383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M content/browser/frame_host/render_frame_proxy_host.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831233004/1
4 years, 9 months ago (2016-03-25 20:27:54 UTC) #3
nasko
Hey Alex, Can you review this code removal CL? Thanks in advance, Nasko
4 years, 9 months ago (2016-03-25 20:28:38 UTC) #5
alexmos
LGTM
4 years, 9 months ago (2016-03-25 20:31:45 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-25 22:04:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831233004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831233004/1
4 years, 9 months ago (2016-03-25 22:11:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 22:18:56 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 22:20:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a949e39cbe5f6ef8bad2e9221af8ee1152be2419
Cr-Commit-Position: refs/heads/master@{#383383}

Powered by Google App Engine
This is Rietveld 408576698