Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1831213002: Remove /RTC1 switch to let debug mini_installer build (Closed)

Created:
4 years, 9 months ago by brucedawson
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove /RTC1 switch to let debug mini_installer build The /RTC1 switch adds references to _RTC_CheckStackVars and _RTC_InitBase which causes msvcrtd.lib to be pulled in which causes gn debug builds of mini_installer to fail. /RTC1 is not used in gyp builds and therefore it should be removed from gn builds unless we decide that it offers enough value to justify the effort required to put it back in. BUG=596885 Committed: https://crrev.com/bc907653b0b0bd505ee0393925517f11713df643 Cr-Commit-Position: refs/heads/master@{#383261}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Returning to original, correct, approved patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
brucedawson
4 years, 9 months ago (2016-03-25 00:46:27 UTC) #2
Dirk Pranke
lgtm.
4 years, 9 months ago (2016-03-25 00:48:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831213002/1
4 years, 9 months ago (2016-03-25 01:03:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831213002/20001
4 years, 9 months ago (2016-03-25 06:02:13 UTC) #8
brucedawson
I accidentally reused the branch and uploaded some other changes. I then undid that so ...
4 years, 9 months ago (2016-03-25 06:05:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831213002/40001
4 years, 9 months ago (2016-03-25 06:05:24 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-25 07:09:26 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 07:10:52 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bc907653b0b0bd505ee0393925517f11713df643
Cr-Commit-Position: refs/heads/master@{#383261}

Powered by Google App Engine
This is Rietveld 408576698