[Telemetry] Always clean up startup config file on Android

[Telemetry] Always clean up startup config file on Android

The config file has fixed path on Android. We need to ensure it is always cleaned up.

BUG=chromium:596464
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/cb46f205b9fb8250ee820de3a4b01a90224206d8

[Zhen Wang, 2016-03-25 00:05:12]

Description was changed from

==========
[Telemetry] Always clean up startup config file on Android

BUG=catapult:#596464
==========

to

==========
[Telemetry] Always clean up startup config file on Android

The config file has fixed path on Android. We need to ensure it is always
cleaned up.

BUG=chromium:596464
==========

[Zhen Wang, 2016-03-25 00:05:57]

zhenw@chromium.org changed reviewers:
+ nednguyen@google.com

[Zhen Wang, 2016-03-25 00:05:57]

ptal

[nednguyen, 2016-03-25 00:23:59]

https://codereview.chromium.org/1831143003/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py
(right):

https://codereview.chromium.org/1831143003/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py:160:
atexit.register(self._RemoveTraceConfigFile)
Where is the place that fail to call StopAgentTracing exactly? I just learn that
the atexit is not bullet proof since if process is killed by SIGTERM, this will
not be called.

[nednguyen, 2016-03-25 00:34:39]

On 2016/03/25 00:23:59, nednguyen wrote:
>
https://codereview.chromium.org/1831143003/diff/1/telemetry/telemetry/interna...
> File
telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py
> (right):
> 
>
https://codereview.chromium.org/1831143003/diff/1/telemetry/telemetry/interna...
>
telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py:160:
> atexit.register(self._RemoveTraceConfigFile)
> Where is the place that fail to call StopAgentTracing exactly? I just learn
that
> the atexit is not bullet proof since if process is killed by SIGTERM, this
will
> not be called.

lgtm & cq so we address the bleeding first. Can you make follow up work to make
sure that the callsite of chrome_tracing_agent is guaranteed to call clean up?

[nednguyen, 2016-03-25 00:34:43]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-03-25 00:34:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831143003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831143003/1

[commit-bot: I haz the power, 2016-03-25 00:48:06]

Description was changed from

==========
[Telemetry] Always clean up startup config file on Android

The config file has fixed path on Android. We need to ensure it is always
cleaned up.

BUG=chromium:596464
==========

to

==========
[Telemetry] Always clean up startup config file on Android

The config file has fixed path on Android. We need to ensure it is always
cleaned up.

BUG=chromium:596464

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-03-25 00:48:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...