Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1831143003: [Telemetry] Always clean up startup config file on Android (Closed)

Created:
4 years, 9 months ago by Zhen Wang
Modified:
4 years, 9 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Always clean up startup config file on Android The config file has fixed path on Android. We need to ensure it is always cleaned up. BUG=chromium:596464 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/cb46f205b9fb8250ee820de3a4b01a90224206d8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py View 2 chunks +4 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (4 generated)
Zhen Wang
ptal
4 years, 9 months ago (2016-03-25 00:05:57 UTC) #3
nednguyen
https://codereview.chromium.org/1831143003/diff/1/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py File telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py (right): https://codereview.chromium.org/1831143003/diff/1/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py#newcode160 telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py:160: atexit.register(self._RemoveTraceConfigFile) Where is the place that fail to call ...
4 years, 9 months ago (2016-03-25 00:23:59 UTC) #4
nednguyen
On 2016/03/25 00:23:59, nednguyen wrote: > https://codereview.chromium.org/1831143003/diff/1/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py > File telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py > (right): > > https://codereview.chromium.org/1831143003/diff/1/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py#newcode160 ...
4 years, 9 months ago (2016-03-25 00:34:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831143003/1
4 years, 9 months ago (2016-03-25 00:34:51 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 00:48:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698