Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1831133005: Consolidate duplicate code for resloving URIs. (Closed)

Created:
4 years, 9 months ago by Paul Berry
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Sort #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -123 lines) Patch
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/context/source.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 2 chunks +0 lines, -20 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 2 chunks +1 line, -26 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 1 chunk +36 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/string_source.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/summary/prelink.dart View 2 chunks +3 lines, -31 lines 0 comments Download
M pkg/analyzer/lib/src/task/html.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 1 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 10 chunks +14 lines, -10 lines 4 comments Download
M pkg/analyzer/test/generated/test_support.dart View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 9 months ago (2016-03-25 12:14:38 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1831133005/diff/20001/pkg/analyzer/test/generated/all_the_rest_test.dart File pkg/analyzer/test/generated/all_the_rest_test.dart (right): https://codereview.chromium.org/1831133005/diff/20001/pkg/analyzer/test/generated/all_the_rest_test.dart#newcode4062 pkg/analyzer/test/generated/all_the_rest_test.dart:4062: expect(source, isNotNull); Do we need to use Source ...
4 years, 9 months ago (2016-03-25 14:02:44 UTC) #3
Paul Berry
Committed patchset #2 (id:20001) manually as 9e52ab17e00276f16246b4652bacaf46f0ec6f45 (presubmit successful).
4 years, 9 months ago (2016-03-25 17:37:45 UTC) #5
Paul Berry
4 years, 9 months ago (2016-03-25 17:37:53 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1831133005/diff/20001/pkg/analyzer/test/gener...
File pkg/analyzer/test/generated/all_the_rest_test.dart (right):

https://codereview.chromium.org/1831133005/diff/20001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/all_the_rest_test.dart:4062: expect(source,
isNotNull);
On 2016/03/25 14:02:44, scheglov wrote:
> Do we need to use Source here at all?
> Maybe we could just parse first argument Uri.

Done.

https://codereview.chromium.org/1831133005/diff/20001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/all_the_rest_test.dart:4064:
resolveRelativeUri(source.uri, parseUriWithException("lib.dart"));
On 2016/03/25 14:02:44, scheglov wrote:
> Maybe this should be moved to a separate test, because it is now independent
of
> Source.

Done.

Powered by Google App Engine
This is Rietveld 408576698