Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1614)

Unified Diff: Source/wtf/PartitionAllocTest.cpp

Issue 183113003: PartitionAlloc: support in-place resize of directly mapped allocation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: nits addressed Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/wtf/PartitionAlloc.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/wtf/PartitionAllocTest.cpp
diff --git a/Source/wtf/PartitionAllocTest.cpp b/Source/wtf/PartitionAllocTest.cpp
index 531fcd4f70a4547e4d6ee1ace34097ab26b30527..28b955e95794e2f39eceb7f338ad80a53474e33e 100644
--- a/Source/wtf/PartitionAllocTest.cpp
+++ b/Source/wtf/PartitionAllocTest.cpp
@@ -692,6 +692,23 @@ TEST(WTF_PartitionAlloc, Realloc)
partitionFreeGeneric(genericAllocator.root(), ptr);
+ // Test that shrinking a direct mapped allocation happens in-place (even
+ // though the new size is smaller than kGenericMaxBucketed).
+ size = WTF::kGenericMaxBucketed + 16 * WTF::kSystemPageSize;
+ ptr = partitionAllocGeneric(genericAllocator.root(), size);
+ size_t actualSize = partitionAllocGetSize(ptr);
+ ptr2 = partitionReallocGeneric(genericAllocator.root(), ptr, WTF::kGenericMaxBucketed - 16 * WTF::kSystemPageSize);
+ EXPECT_EQ(ptr, ptr2);
+ EXPECT_EQ(actualSize - 32 * WTF::kSystemPageSize, partitionAllocGetSize(ptr2));
+
+ // Test that a previously in-place shrunk direct mapped allocation can be
+ // expanded up again within its original size.
+ ptr = partitionReallocGeneric(genericAllocator.root(), ptr2, size - WTF::kSystemPageSize);
+ EXPECT_EQ(ptr2, ptr);
+ EXPECT_EQ(actualSize - WTF::kSystemPageSize, partitionAllocGetSize(ptr));
+
+ partitionFreeGeneric(genericAllocator.root(), ptr);
+
TestShutdown();
}
« no previous file with comments | « Source/wtf/PartitionAlloc.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698