MD Settings: Certificate manager, respect USE_NSS_CERTS.

MD Settings: Certificate manager, respect USE_NSS_CERTS.

Specifically, including certificate manager only when
USE_NSS_CERTS is true. Also updating strings, resources and
tests accordingly.

BUG=547073
Committed: https://crrev.com/9955328cf27c93eeb74d88dde61e332c00448d95
Cr-Commit-Position: refs/heads/master@{#383310}

[dpapad, 2016-03-24 19:46:26]

Description was changed from

==========
Experiment with use_nss_certs if expr, WIP.

BUG=
==========

to

==========
MD Settings: Certificate manager, respect USE_NSS_CERTS.

BUG=547073
==========

[dpapad, 2016-03-24 20:43:30]

Description was changed from

==========
MD Settings: Certificate manager, respect USE_NSS_CERTS.

BUG=547073
==========

to

==========
MD Settings: Certificate manager, respect USE_NSS_CERTS.

Specifically, including certificate manager only when USE_NSS_CERTS is true.
Also updating strings, resources and tests accordingly.

BUG=547073
==========

[dpapad, 2016-03-24 20:44:16]

Description was changed from

==========
MD Settings: Certificate manager, respect USE_NSS_CERTS.

Specifically, including certificate manager only when USE_NSS_CERTS is true.
Also updating strings, resources and tests accordingly.

BUG=547073
==========

to

==========
MD Settings: Certificate manager, respect USE_NSS_CERTS.

Specifically, including certificate manager only when
USE_NSS_CERTS is true. Also updating strings, resources and
tests accordingly.

BUG=547073
==========

[dpapad, 2016-03-24 21:31:51]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-03-25 02:21:18]

lgtm w/nit

https://codereview.chromium.org/1831093002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/1831093002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:82: </if>
can you just do this in the javascript instead?

https://codereview.chromium.org/1831093002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.js (right):

https://codereview.chromium.org/1831093002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.js:52: 
maybe something like:

  onManageCertificatesTap_: function() {
<if expr="use_nss">
    this.$.pages.setSubpageChain(['manage-certificates']);
</if>
<if expr="not use_nss">
    this.browserProxy_.doSomethingNative();
</if>
  },

[dpapad, 2016-03-25 16:56:55]

https://codereview.chromium.org/1831093002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/1831093002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:82: </if>
On 2016/03/25 at 02:21:18, Dan Beam wrote:
> can you just do this in the javascript instead?

Done.

https://codereview.chromium.org/1831093002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.js (right):

https://codereview.chromium.org/1831093002/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.js:52: 
On 2016/03/25 at 02:21:18, Dan Beam wrote:
> maybe something like:
> 
>   onManageCertificatesTap_: function() {
> <if expr="use_nss">
>     this.$.pages.setSubpageChain(['manage-certificates']);
> </if>
> <if expr="not use_nss">
>     this.browserProxy_.doSomethingNative();
> </if>
>   },

Done.

[dpapad, 2016-03-25 16:57:10]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-03-25 16:57:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1831093002/#ps100001
(title: "Move ifdef to  JS file.")

[commit-bot: I haz the power, 2016-03-25 16:57:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831093002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831093002/100001

[commit-bot: I haz the power, 2016-03-25 18:09:32]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-25 18:11:38]

Description was changed from

==========
MD Settings: Certificate manager, respect USE_NSS_CERTS.

Specifically, including certificate manager only when
USE_NSS_CERTS is true. Also updating strings, resources and
tests accordingly.

BUG=547073
==========

to

==========
MD Settings: Certificate manager, respect USE_NSS_CERTS.

Specifically, including certificate manager only when
USE_NSS_CERTS is true. Also updating strings, resources and
tests accordingly.

BUG=547073

Committed: https://crrev.com/9955328cf27c93eeb74d88dde61e332c00448d95
Cr-Commit-Position: refs/heads/master@{#383310}
==========

[commit-bot: I haz the power, 2016-03-25 18:11:39]

Patchset 6 (id:??) landed as
https://crrev.com/9955328cf27c93eeb74d88dde61e332c00448d95
Cr-Commit-Position: refs/heads/master@{#383310}