Check for proper types from error handling code

Check for proper types from error handling code

A bug in error printing meant that we failed to do proper type checks
before calling into C++ code, which could lead to RUNTIME_ASSERT
failures if methods are called on alternative receivers. This patch
adds the right type checks.

BUG=chromium:596718
LOG=Y
R=adamk

Committed: https://crrev.com/97fce6214e946ad5c1e09656a0317308a75f3dc3
Cr-Commit-Position: refs/heads/master@{#35069}

[Dan Ehrenberg, 2016-03-24 20:56:51]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 20:56:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831053003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831053003/20001

[commit-bot: I haz the power, 2016-03-24 21:01:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 21:01:45]

Dry run: Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/12875)

[adamk, 2016-03-24 21:03:11]

https://codereview.chromium.org/1831053003/diff/20001/src/js/messages.js
File src/js/messages.js (right):

https://codereview.chromium.org/1831053003/diff/20001/src/js/messages.js#newc...
src/js/messages.js:574: if (!IS_RECEIVER(obj) || !HAS_PRIVATE(obj,
callSiteFunctionSymbol)) {
Remind me, does HAS_PRIVATE always return false for proxies? I can't recall what
we ended up with. If not, you'll also want a !IS_PROXY(obj) check too.

Please also add a test where you pass a Proxy as the receiver.

[Dan Ehrenberg, 2016-03-24 21:39:07]

https://codereview.chromium.org/1831053003/diff/20001/src/js/messages.js
File src/js/messages.js (right):

https://codereview.chromium.org/1831053003/diff/20001/src/js/messages.js#newc...
src/js/messages.js:574: if (!IS_RECEIVER(obj) || !HAS_PRIVATE(obj,
callSiteFunctionSymbol)) {
On 2016/03/24 at 21:03:11, adamk wrote:
> Remind me, does HAS_PRIVATE always return false for proxies? I can't recall
what we ended up with. If not, you'll also want a !IS_PROXY(obj) check too.
> 
> Please also add a test where you pass a Proxy as the receiver.

Private symbols don't forward through Proxies. I added a test to verify that a
TypeError is properly thrown in this case.

[adamk, 2016-03-24 21:43:08]

+yangguo FYI, but lgtm to quiet ClusterFuzz

[Dan Ehrenberg, 2016-03-24 21:55:33]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-03-24 21:55:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831053003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831053003/40001

[commit-bot: I haz the power, 2016-03-24 22:10:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 22:10:09]

Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Dan Ehrenberg, 2016-03-24 22:36:23]

littledan@chromium.org changed reviewers:
+ rmcilroy@chromium.org, ssanfilippo@chromium.org

[Dan Ehrenberg, 2016-03-24 22:36:47]

Ross, Stefano, could you take a look at the bytecode expectations changes that
this leads to?

[adamk, 2016-03-24 23:53:26]

On 2016/03/24 22:36:47, Dan Ehrenberg wrote:
> Ross, Stefano, could you take a look at the bytecode expectations changes that
> this leads to?

Did you see failures on the trybots for IfConditions? It looks to me like that
one didn't fail, and ForOf is just changing because of message IDs. I'd try
leaving IfConditions out of this patch and hitting the CQ button again.

[Dan Ehrenberg, 2016-03-24 23:55:55]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 23:56:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831053003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831053003/80001

[commit-bot: I haz the power, 2016-03-25 00:11:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 00:11:23]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)

[Dan Ehrenberg, 2016-03-25 00:28:44]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 00:28:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831053003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831053003/100001

[commit-bot: I haz the power, 2016-03-25 00:57:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 00:57:33]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-03-25 02:04:41]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-03-25 02:04:41]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1831053003/#ps100001
(title: "rebase golden again")

[commit-bot: I haz the power, 2016-03-25 02:04:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831053003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831053003/100001

[commit-bot: I haz the power, 2016-03-25 02:08:52]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-25 02:10:08]

Description was changed from

==========
Check for proper types from error handling code

A bug in error printing meant that we failed to do proper type checks
before calling into C++ code, which could lead to RUNTIME_ASSERT
failures if methods are called on alternative receivers. This patch
adds the right type checks.

BUG=chromium:596718
LOG=Y
R=adamk
==========

to

==========
Check for proper types from error handling code

A bug in error printing meant that we failed to do proper type checks
before calling into C++ code, which could lead to RUNTIME_ASSERT
failures if methods are called on alternative receivers. This patch
adds the right type checks.

BUG=chromium:596718
LOG=Y
R=adamk

Committed: https://crrev.com/97fce6214e946ad5c1e09656a0317308a75f3dc3
Cr-Commit-Position: refs/heads/master@{#35069}
==========

[commit-bot: I haz the power, 2016-03-25 02:10:09]

Patchset 6 (id:??) landed as
https://crrev.com/97fce6214e946ad5c1e09656a0317308a75f3dc3
Cr-Commit-Position: refs/heads/master@{#35069}