Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1831053002: Relocate SK_SUPPORT_LEGACY_PICTURE_PTR (Closed)

Created:
4 years, 9 months ago by f(malita)
Modified:
4 years, 9 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Relocate SK_SUPPORT_LEGACY_PICTURE_PTR Move to platform-specific defines. (Chromium already has this guard) R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1831053002 Committed: https://skia.googlesource.com/skia/+/41c409634cb9ac01afd1ead4442d7c10817b3e33

Patch Set 1 #

Patch Set 2 : picture_demo.cpp fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M experimental/nanomsg/picture_demo.cpp View 1 5 chunks +11 lines, -4 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public.bzl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
f(malita)
4 years, 9 months ago (2016-03-24 17:39:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831053002/1
4 years, 9 months ago (2016-03-24 17:39:39 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-24 17:39:40 UTC) #5
reed1
lgtm
4 years, 9 months ago (2016-03-24 17:39:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/1465)
4 years, 9 months ago (2016-03-24 17:41:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831053002/20001
4 years, 9 months ago (2016-03-24 17:49:48 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 18:05:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/41c409634cb9ac01afd1ead4442d7c10817b3e33

Powered by Google App Engine
This is Rietveld 408576698