Fix Subzero binary instruction to allow optional flags argument.

src/PNaClTranslator.cpp

Index: src/PNaClTranslator.cpp
diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp
index caa0c57c6a05052f1d2926d63039102baba66301..34a0985768842882a652c83686c343cdbb3ca980 100644
--- a/src/PNaClTranslator.cpp
+++ b/src/PNaClTranslator.cpp
@@ -2198,8 +2198,9 @@ void FunctionParser::ProcessRecord() {
     return;
   }
   case naclbitc::FUNC_CODE_INST_BINOP: {
-    // BINOP: [opval, opval, opcode]
-    if (!isValidRecordSize(3, "binop"))
+    // BINOP: [opval, opval, opcode, [flags]] Note: Old bitcode files may have

[Jim Stichnoth, 2016/03/24 20:53:58]

Maybe "Note:" should start on a new line?

[Karl, 2016/03/24 22:54:41]

Done.

+    // an additional 'flags" operand, which is ignored.

[Jim Stichnoth, 2016/03/24 20:53:58]

'flags' or "flags"

[Karl, 2016/03/24 22:54:41]

Done.

+    if (!isValidRecordSizeInRange(3, 4, "binop"))
       return;
     Ice::Operand *Op1 = getRelativeOperand(Values[0], BaseIndex);
     Ice::Operand *Op2 = getRelativeOperand(Values[1], BaseIndex);