Fix Subzero binary instruction to allow optional flags argument.

src/PNaClTranslator.cpp

Index: src/PNaClTranslator.cpp
diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp
index caa0c57c6a05052f1d2926d63039102baba66301..11720f2a5ec8f86ff607800105fa9039242eada9 100644
--- a/src/PNaClTranslator.cpp
+++ b/src/PNaClTranslator.cpp
@@ -2198,8 +2198,10 @@ void FunctionParser::ProcessRecord() {
     return;
   }
   case naclbitc::FUNC_CODE_INST_BINOP: {
-    // BINOP: [opval, opval, opcode]
-    if (!isValidRecordSize(3, "binop"))
+    // BINOP: [opval, opval, opcode, [flags]]
+    // Note: Old bitcode files may have an additional 'flags" operand, and

[Jim Stichnoth, 2016/03/24 17:46:32]

s/and/which/

and maybe reflow the comment

[Karl, 2016/03/24 19:28:36]

Done.

+    // is ignored.
+    if (!isValidRecordSizeInRange(3, 4, "binop"))
       return;
     Ice::Operand *Op1 = getRelativeOperand(Values[0], BaseIndex);
     Ice::Operand *Op2 = getRelativeOperand(Values[1], BaseIndex);