Source/core/rendering/RenderBox.h - Issue 183103007: Implement will-change-based GPU rasterization hint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.h

Issue 183103007: Implement will-change-based GPU rasterization hint (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/compositing/will-change/gpu-rasterization-hint.html ('K') | « Source/core/frame/Settings.in ('k') | Source/core/rendering/RenderBoxModelObject.h » ('j') | Source/core/rendering/style/RenderStyle.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBox.h

diff --git a/Source/core/rendering/RenderBox.h b/Source/core/rendering/RenderBox.h

index 588e4502e84e88dd2b8dcdfab26c7da13320cc4e..2d17672497ddffcf1ffa384aa1d10206163bf911 100644

--- a/Source/core/rendering/RenderBox.h

+++ b/Source/core/rendering/RenderBox.h

@@ -71,7 +71,7 @@ public:

// position:static elements that are not flex-items get their z-index coerced to auto.

virtual LayerType layerTypeRequired() const OVERRIDE

{

- if (isRoot() || isPositioned() || createsGroup() || hasClipPath() || hasTransform() || hasHiddenBackface() || hasReflection() || style()->specifiesColumns() || !style()->hasAutoZIndex() || style()->hasWillChangeCompositingHint())

+ if (isRoot() || isPositioned() || createsGroup() || hasClipPath() || hasTransform() || hasHiddenBackface() || hasReflection() || style()->specifiesColumns() || !style()->hasAutoZIndex() || style()->hasWillChangeCompositingHint() || style()->hasWillChangeCompositingHint())

abarth-chromium 2014/03/07 16:04:39 Why do we need this twice? Maybe you meant hasWil

ajuma 2014/03/07 17:03:41 Indeed, thanks for catching that!

return NormalLayer;

if (hasOverflowClip())

return OverflowClipLayer;