Issue 18310003: Grokdump: new shell command, "lm"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18310003: Grokdump: new shell command, "lm" (Closed)

Created:
7 years, 5 months ago by mvstanton

Modified:
7 years, 5 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Grokdump: new shell command, "lm" lm - list matching modules and details such as product version number found in the minidump. Also, enabled a mode to execute one command and exit. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15410

Patch Set 1 #

Patch Set 2 : Whitespace issue #

Total comments: 2

Patch Set 3 : Fixed nits and enabled code behind a TODO #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -13 lines)			Patch
	M	tools/grokdump.py	View	1 2	9 chunks	+71 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with nits. https://codereview.chromium.org/18310003/diff/2001/tools/grokdump.py File tools/grokdump.py (right): https://codereview.chromium.org/18310003/diff/2001/tools/grokdump.py#newcode42 tools/grokdump.py:42: import datetime nit: Can we alpha-sort ...

7 years, 5 months ago (2013-07-01 11:17:37 UTC) #2

mvstanton

Thanks, I addressed and also enabled the module printing for known modules. The problem was ...

7 years, 5 months ago (2013-07-01 11:36:11 UTC) #3

mvstanton

7 years, 5 months ago (2013-07-01 11:37:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r15410 (presubmit successful).

Expand Messages | Collapse Messages