Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: components/gcm_driver/instance_id/instance_id.h

Issue 1830983002: Implement InstanceIDAndroid using InstanceIDWithSubtype.java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid1subtype
Patch Set: Make mNativeInstanceIDAndroid non-final Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/instance_id/instance_id.h
diff --git a/components/gcm_driver/instance_id/instance_id.h b/components/gcm_driver/instance_id/instance_id.h
index fb69a11ef7776187fd5b9695521b8d55a355c3ea..de9bc215aa71e216f7ffc307b65f938f41ebaff5 100644
--- a/components/gcm_driver/instance_id/instance_id.h
+++ b/components/gcm_driver/instance_id/instance_id.h
@@ -57,7 +57,7 @@ class InstanceID {
// Creator.
// |app_id|: identifies the application that uses the Instance ID.
// |handler|: provides the GCM functionality needed to support Instance ID.
- // Must outlive this class.
+ // Must outlive this class. On Android, this can be null instead.
static scoped_ptr<InstanceID> Create(const std::string& app_id,
gcm::InstanceIDHandler* handler);
@@ -106,17 +106,11 @@ class InstanceID {
std::string app_id() const { return app_id_; }
protected:
- InstanceID(const std::string& app_id, gcm::InstanceIDHandler* handler);
+ InstanceID(const std::string& app_id);
void NotifyTokenRefresh(bool update_id);
- gcm::InstanceIDHandler* handler() const { return handler_; }
-
private:
- // Owned by GCMProfileServiceFactory, which is a dependency of
- // InstanceIDProfileServiceFactory, which owns this.
- gcm::InstanceIDHandler* handler_;
-
std::string app_id_;
TokenRefreshCallback token_refresh_callback_;

Powered by Google App Engine
This is Rietveld 408576698