components/gcm_driver/instance_id/instance_id.cc - Issue 1830983002: Implement InstanceIDAndroid using InstanceIDWithSubtype.java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/instance_id/instance_id.cc

Issue 1830983002: Implement InstanceIDAndroid using InstanceIDWithSubtype.java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid1subtype

Patch Set: Improve comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/gcm_driver/instance_id/android/java/src/org/chromium/components/gcm_driver/instance_id/InstanceIDBridge.java ('K') | « components/gcm_driver/instance_id/instance_id.h ('k') | components/gcm_driver/instance_id/instance_id_android.h » ('j') | components/gcm_driver/instance_id/instance_id_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/instance_id/instance_id.cc

diff --git a/components/gcm_driver/instance_id/instance_id.cc b/components/gcm_driver/instance_id/instance_id.cc

index d89c997efe3d91cd39b861df3ce75a2eda2cacaa..d48b5cafe34ccc49a9a48d04189cea834ccd4d55 100644

--- a/components/gcm_driver/instance_id/instance_id.cc

+++ b/components/gcm_driver/instance_id/instance_id.cc

@@ -6,14 +6,9 @@

namespace instance_id {

-InstanceID::InstanceID(const std::string& app_id,

- gcm::InstanceIDHandler* handler)

- : handler_(handler), app_id_(app_id) {

- DCHECK(handler_);

+InstanceID::InstanceID(const std::string& app_id) : app_id_(app_id) {}

-InstanceID::~InstanceID() {

+InstanceID::~InstanceID() {}

void InstanceID::SetTokenRefreshCallback(const TokenRefreshCallback& callback) {

token_refresh_callback_ = callback;