Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1830973002: Convert Gray8 images to N32 before uploading. Previously, we were (Closed)

Created:
4 years, 9 months ago by Brian Osman
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Convert Gray8 images to N32 before uploading. Previously, we were treating them as Alpha8, which was wrong. Fixes incorrect images on the filterbitmap_image_mandrill_64.png_g8 GM. BUG=skia:4822 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1830973002 Committed: https://skia.googlesource.com/skia/+/85f9269d9b05c25f3d7b9ac5435f2bf8951e7db3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M src/gpu/SkGr.cpp View 2 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Brian Osman
4 years, 9 months ago (2016-03-24 13:39:17 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830973002/1
4 years, 9 months ago (2016-03-24 13:39:29 UTC) #5
bsalomon
lgtm
4 years, 9 months ago (2016-03-24 13:52:32 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-24 13:54:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830973002/1
4 years, 9 months ago (2016-03-24 13:55:41 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 13:56:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/85f9269d9b05c25f3d7b9ac5435f2bf8951e7db3

Powered by Google App Engine
This is Rietveld 408576698