Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: Source/devtools/front_end/NetworkPanel.js

Issue 183093010: Tooltip wording inconsistent for document loaded events. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 542 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 553
554 this._timelineGrid.removeEventDividers(); 554 this._timelineGrid.removeEventDividers();
555 if (this._mainRequestLoadTime !== -1) { 555 if (this._mainRequestLoadTime !== -1) {
556 var percent = this.calculator.computePercentageFromEventTime(this._m ainRequestLoadTime); 556 var percent = this.calculator.computePercentageFromEventTime(this._m ainRequestLoadTime);
557 557
558 var loadDivider = document.createElement("div"); 558 var loadDivider = document.createElement("div");
559 loadDivider.className = "network-event-divider network-red-divider"; 559 loadDivider.className = "network-event-divider network-red-divider";
560 560
561 var loadDividerPadding = document.createElement("div"); 561 var loadDividerPadding = document.createElement("div");
562 loadDividerPadding.className = "network-event-divider-padding"; 562 loadDividerPadding.className = "network-event-divider-padding";
563 loadDividerPadding.title = WebInspector.UIString("Load event fired") ; 563 loadDividerPadding.title = WebInspector.UIString("Load event");
564 loadDividerPadding.appendChild(loadDivider); 564 loadDividerPadding.appendChild(loadDivider);
565 loadDividerPadding.style.left = percent + "%"; 565 loadDividerPadding.style.left = percent + "%";
566 this._timelineGrid.addEventDivider(loadDividerPadding); 566 this._timelineGrid.addEventDivider(loadDividerPadding);
567 } 567 }
568 568
569 if (this._mainRequestDOMContentLoadedTime !== -1) { 569 if (this._mainRequestDOMContentLoadedTime !== -1) {
570 var percent = this.calculator.computePercentageFromEventTime(this._m ainRequestDOMContentLoadedTime); 570 var percent = this.calculator.computePercentageFromEventTime(this._m ainRequestDOMContentLoadedTime);
571 571
572 var domContentLoadedDivider = document.createElement("div"); 572 var domContentLoadedDivider = document.createElement("div");
573 domContentLoadedDivider.className = "network-event-divider network-b lue-divider"; 573 domContentLoadedDivider.className = "network-event-divider network-b lue-divider";
574 574
575 var domContentLoadedDividerPadding = document.createElement("div"); 575 var domContentLoadedDividerPadding = document.createElement("div");
576 domContentLoadedDividerPadding.className = "network-event-divider-pa dding"; 576 domContentLoadedDividerPadding.className = "network-event-divider-pa dding";
577 domContentLoadedDividerPadding.title = WebInspector.UIString("DOMCon tentLoaded event fired"); 577 domContentLoadedDividerPadding.title = WebInspector.UIString("DOMCon tentLoaded event");
578 domContentLoadedDividerPadding.appendChild(domContentLoadedDivider); 578 domContentLoadedDividerPadding.appendChild(domContentLoadedDivider);
579 domContentLoadedDividerPadding.style.left = percent + "%"; 579 domContentLoadedDividerPadding.style.left = percent + "%";
580 this._timelineGrid.addEventDivider(domContentLoadedDividerPadding); 580 this._timelineGrid.addEventDivider(domContentLoadedDividerPadding);
581 } 581 }
582 }, 582 },
583 583
584 _refreshIfNeeded: function() 584 _refreshIfNeeded: function()
585 { 585 {
586 if (this._needsRefresh) 586 if (this._needsRefresh)
587 this.refresh(); 587 this.refresh();
(...skipping 2112 matching lines...) Expand 10 before | Expand all | Expand 10 after
2700 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyNa me, revert, a, b) 2700 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyNa me, revert, a, b)
2701 { 2701 {
2702 var aValue = a._request[propertyName]; 2702 var aValue = a._request[propertyName];
2703 var bValue = b._request[propertyName]; 2703 var bValue = b._request[propertyName];
2704 if (aValue > bValue) 2704 if (aValue > bValue)
2705 return revert ? -1 : 1; 2705 return revert ? -1 : 1;
2706 if (bValue > aValue) 2706 if (bValue > aValue)
2707 return revert ? 1 : -1; 2707 return revert ? 1 : -1;
2708 return 0; 2708 return 0;
2709 } 2709 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698