git cl: refactor Changelist codereview detection.

git cl: refactor Changelist codereview detection.

BUG=579160
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299464

[tandrii(chromium), 2016-03-24 10:43:26]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 10:43:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830923002/1

[tandrii(chromium), 2016-03-24 10:43:45]

Description was changed from

==========
git cl: refactor Changelist codereview detection.

BUG=
==========

to

==========
git cl: refactor Changelist codereview detection.

BUG=579160
==========

[commit-bot: I haz the power, 2016-03-24 10:46:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 10:46:03]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-03-24 11:19:46]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 11:19:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830923002/20001

[tandrii(chromium), 2016-03-24 11:20:35]

tandrii@chromium.org changed reviewers:
+ machenbach@chromium.org, sergiyb@chromium.org

[tandrii(chromium), 2016-03-24 11:20:35]

PTAL

this is the idea I got after both of you commented on the confusing tmp_rietveld
variable.

[Sergiy Byelozyorov, 2016-03-24 11:30:51]

I still feel that this could be written better, but not sure how, so go ahead
and land.

lgtm w/ a nit

https://codereview.chromium.org/1830923002/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1830923002/diff/20001/git_cl.py#newcode910
git_cl.py:910: # OK, no issue is set for this branch, so decide based on
repo-wide settings.
nit: line too long

[tandrii(chromium), 2016-03-24 11:32:40]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2016-03-24 11:32:40]

The patchset sent to the CQ was uploaded after l-g-t-m from sergiyb@chromium.org
Link to the patchset: https://codereview.chromium.org/1830923002/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2016-03-24 11:32:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830923002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830923002/60001

[commit-bot: I haz the power, 2016-03-24 11:34:59]

Description was changed from

==========
git cl: refactor Changelist codereview detection.

BUG=579160
==========

to

==========
git cl: refactor Changelist codereview detection.

BUG=579160

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299464
==========

[commit-bot: I haz the power, 2016-03-24 11:35:00]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299464

[Michael Achenbach, 2016-03-24 12:44:54]

lgtm. I like it better that way. Calling a static method is an improvement over
instantiating the whole class.

https://codereview.chromium.org/1830923002/diff/60001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1830923002/diff/60001/git_cl.py#newcode911
git_cl.py:911: return self._load_codereview_impl(
nit: indentation

[tandrii(chromium), 2016-03-24 12:48:48]

https://codereview.chromium.org/1830923002/diff/60001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1830923002/diff/60001/git_cl.py#newcode911
git_cl.py:911: return self._load_codereview_impl(
On 2016/03/24 12:44:54, Michael Achenbach wrote:
> nit: indentation

fix: https://codereview.chromium.org/1830703004

[tandrii(chromium), 2016-03-24 17:32:45]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1826203003/ by tandrii@chromium.org.

The reason for reverting is: broke presubmit.