Renders the profile name button in profile chooser view for supervised user.

Renders the profile name button in profile chooser view for supervised user.

BUG=596423
Committed: https://crrev.com/ee6ba2af8c8cc70e1b12d22e3e68a9244145a253
Cr-Commit-Position: refs/heads/master@{#383254}

[Shu Chen, 2016-03-25 01:50:12]

shuchen@chromium.org changed reviewers:
+ pkasting@chromium.org

[Shu Chen, 2016-03-25 01:50:12]

Peter, can you please review this cl? Thanks.

[Shu Chen, 2016-03-25 01:50:45]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 01:51:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830903006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830903006/1

[commit-bot: I haz the power, 2016-03-25 02:37:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 02:37:37]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2016-03-25 04:34:45]

LGTM

https://codereview.chromium.org/1830903006/diff/1/chrome/browser/ui/views/pro...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (left):

https://codereview.chromium.org/1830903006/diff/1/chrome/browser/ui/views/pro...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:433: new
views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0));
We don't need this to be moved up as well, because we only have one child in the
early return case, right?

[Shu Chen, 2016-03-25 05:48:11]

https://codereview.chromium.org/1830903006/diff/1/chrome/browser/ui/views/pro...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (left):

https://codereview.chromium.org/1830903006/diff/1/chrome/browser/ui/views/pro...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:433: new
views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0));
On 2016/03/25 04:34:45, Peter Kasting wrote:
> We don't need this to be moved up as well, because we only have one child in
the
> early return case, right?

Yes, that is right.

[Shu Chen, 2016-03-25 05:48:20]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2016-03-25 05:48:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830903006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830903006/1

[commit-bot: I haz the power, 2016-03-25 05:53:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-25 05:55:19]

Description was changed from

==========
Renders the profile name button in profile chooser view for supervised user.

BUG=596423
==========

to

==========
Renders the profile name button in profile chooser view for supervised user.

BUG=596423

Committed: https://crrev.com/ee6ba2af8c8cc70e1b12d22e3e68a9244145a253
Cr-Commit-Position: refs/heads/master@{#383254}
==========

[commit-bot: I haz the power, 2016-03-25 05:55:19]

Patchset 1 (id:??) landed as
https://crrev.com/ee6ba2af8c8cc70e1b12d22e3e68a9244145a253
Cr-Commit-Position: refs/heads/master@{#383254}

[Shu Chen, 2016-03-27 08:08:06]

https://codereview.chromium.org/1830903006/diff/1/chrome/browser/ui/views/pro...
File chrome/browser/ui/views/profiles/profile_chooser_view.cc (left):

https://codereview.chromium.org/1830903006/diff/1/chrome/browser/ui/views/pro...
chrome/browser/ui/views/profiles/profile_chooser_view.cc:433: new
views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0));
On 2016/03/25 05:48:11, Shu Chen wrote:
> On 2016/03/25 04:34:45, Peter Kasting wrote:
> > We don't need this to be moved up as well, because we only have one child in
> the
> > early return case, right?
> 
> Yes, that is right.

Sorry, the issue still repro on the latest canary.
You're correct about the layout manager.
The SetLayoutManager() should move up otherwise the button's size cannot be
correctly set.
I will make a cl to fix that.