Fix GetNSExecutablePath for running tests with relative path

base/base_paths_mac.mm

Index: base/base_paths_mac.mm
diff --git a/base/base_paths_mac.mm b/base/base_paths_mac.mm
index 1e8bac80b7f2aa40238270b7f8f2e5c81c7239cf..db900b874ca07da9f3f9d5e84903494a5a069a66 100644
--- a/base/base_paths_mac.mm
+++ b/base/base_paths_mac.mm
@@ -32,7 +32,11 @@ void GetNSExecutablePath(base::FilePath* path) {
   int rv = _NSGetExecutablePath(WriteInto(&executable_path, executable_length),
                                 &executable_length);
   DCHECK_EQ(rv, 0);
-  *path = base::FilePath(executable_path);
+
+  // _NSGetExecutablePath may return paths containing ./ or ../ which makes
+  // FilePath::DirName() work incorrectly, convert it to absolute path so that
+  // paths such as DIR_SOURCE_ROOT can work.
+  *path = base::MakeAbsoluteFilePath(base::FilePath(executable_path));

[Nico, 2013/07/10 18:02:31]

Hm, are you sure these paths never get persisted somewhere? Maybe callers of
this should normpath() instead?

…looks like win and linux return full paths too, so I suppose this is fine.

[brettw, 2013/08/06 04:52:06]

We do want an absolute path here. We should be sure this is the best solution. I
think MakeAbsoluteFilePath does I/O on Posix, which we'd want to avoid if
possible (since I think this function is called on the UI thread). But I don't
have any better ideas.

I think if we're sure this is best the comment would be better worded to just
say that we expect absolute paths to be returned here, since I think DirName()
is probably doing the right thing with the input we're giving it (or it not, we
should fix it).

 }
 
 // Returns true if the module for |address| is found. |path| will contain