third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 1830883002: Add blink::ServiceRegistry and expose it from LocalFrame and Platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1830883002: Add blink::ServiceRegistry and expose it from LocalFrame and Platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp ('k') | third_party/WebKit/public/blink_headers.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 9da68fd534fb7f4ac3e7987d08a3fdc854a7ccb1..9166284ff3b5fa6386294b51007dca982963bba5 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -185,6 +185,7 @@

#include "platform/weborigin/KURL.h"

#include "platform/weborigin/SchemeRegistry.h"

#include "platform/weborigin/SecurityPolicy.h"

+#include "public/platform/ServiceRegistry.h"

#include "public/platform/WebFloatPoint.h"

#include "public/platform/WebFloatRect.h"

#include "public/platform/WebLayer.h"

@@ -1427,7 +1428,7 @@ WebLocalFrameImpl* WebLocalFrameImpl::createProvisional(WebFrameClient* client,

// disappear, so Page::m_mainFrame can't be updated just yet.

RawPtr<FrameOwner> tempOwner = DummyFrameOwner::create();

// TODO(dcheng): This block is very similar to initializeCoreFrame. Try to reuse it here.

- RawPtr<LocalFrame> frame = LocalFrame::create(webFrame->m_frameLoaderClientImpl.get(), oldFrame->host(), tempOwner.get());

+ RawPtr<LocalFrame> frame = LocalFrame::create(webFrame->m_frameLoaderClientImpl.get(), oldFrame->host(), tempOwner.get(), client ? client->serviceRegistry() : nullptr);

// Set the name and unique name directly, bypassing any of the normal logic

// to calculate unique name.

frame->tree().setPrecalculatedName(toWebRemoteFrameImpl(oldWebFrame)->frame()->tree().name(), toWebRemoteFrameImpl(oldWebFrame)->frame()->tree().uniqueName());

@@ -1552,7 +1553,7 @@ void WebLocalFrameImpl::setCoreFrame(RawPtr<LocalFrame> frame)

void WebLocalFrameImpl::initializeCoreFrame(FrameHost* host, FrameOwner* owner, const AtomicString& name, const AtomicString& uniqueName)

{

- setCoreFrame(LocalFrame::create(m_frameLoaderClientImpl.get(), host, owner));

+ setCoreFrame(LocalFrame::create(m_frameLoaderClientImpl.get(), host, owner, client() ? client()->serviceRegistry() : nullptr));

frame()->tree().setPrecalculatedName(name, uniqueName);

// We must call init() after m_frame is assigned because it is referenced

// during init(). Note that this may dispatch JS events; the frame may be