content/public/test/render_view_test.cc - Issue 1830883002: Add blink::ServiceRegistry and expose it from LocalFrame and Platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/render_view_test.cc

Issue 1830883002: Add blink::ServiceRegistry and expose it from LocalFrame and Platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/test/render_view_test.cc

diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc

index 642d4277cb2e5d6796dc1b94fb6b3e05efb3d27d..cd641a41b5f814ace1bd016ef13dff9abc60efb5 100644

--- a/content/public/test/render_view_test.cc

+++ b/content/public/test/render_view_test.cc

@@ -172,7 +172,8 @@ class RendererBlinkPlatformImplTestOverrideImpl

public:

RendererBlinkPlatformImplTestOverrideImpl(

scheduler::RendererScheduler* scheduler)

- : RendererBlinkPlatformImpl(scheduler) {}

+ : RendererBlinkPlatformImpl(scheduler, base::WeakPtr<ServiceRegistry>()) {

dcheng 2016/03/31 20:16:08 Nit: nullptr?

Sam McNally 2016/04/05 02:34:51 WeakPtr doesn't have a nullptr_t constructor.

+ }

// Get rid of the dependency to the sandbox, which is not available in

// RenderViewTest.

« no previous file with comments | « content/content_renderer.gypi ('k') | content/renderer/mojo/blink_service_registry_impl.h » ('j') | content/renderer/render_thread_impl.cc » ('J')