ipc/ipc_message_utils.cc - Issue 1830853002: Make PlatformFileForTransit a class on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_message_utils.cc

Issue 1830853002: Make PlatformFileForTransit a class on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from mseaborn. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_message_utils.cc

diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc

index 29fa0382546d0210158a3b9cfaae9ca6c73c4edb..2420bdb1f1aac600b9937e025b364358c6b9702d 100644

--- a/ipc/ipc_message_utils.cc

+++ b/ipc/ipc_message_utils.cc

@@ -780,7 +780,7 @@ void ParamTraits<base::SharedMemoryHandle>::Write(base::Pickle* m,

// If the caller intended to pass ownership to the IPC stack, release a

// reference.

- if (p.OwnershipPassesToIPC())

+ if (p.OwnershipPassesToIPC() && p.BelongsToCurrentProcess())

p.Close();

} else {

m->WriteInt(HandleToLong(p.GetHandle()));

« no previous file with comments | « content/common/sandbox_util.cc ('k') | ipc/ipc_platform_file.h » ('j') | no next file with comments »