Track USB endpoint state in Blink.

Track USB endpoint state in Blink.

The last in a series of patches putting input validation for the WebUSB
directly into Blink. This one adds bit vectors that track which
endpoints are available given the current set of claimed interfaces and
selected alternate interfaces.

BUG=593164
Committed: https://crrev.com/6cfa6305dc22be1489cec97f8ddcf595d75f2a75
Cr-Commit-Position: refs/heads/master@{#383194}

[Reilly Grant (use Gerrit), 2016-03-23 23:55:25]

reillyg@chromium.org changed reviewers:
+ juncai@chromium.org

[Reilly Grant (use Gerrit), 2016-03-23 23:55:26]

Please take a look.

[juncai, 2016-03-24 17:47:46]

https://codereview.chromium.org/1830833002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webusb/USBDevice.cpp (right):

https://codereview.chromium.org/1830833002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:457:
setEndpointsForInterface(interfaceIndex, false);
nit: add comment for false parameter.

https://codereview.chromium.org/1830833002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:477:
setEndpointsForInterface(interfaceIndex, false);
ditto.

https://codereview.chromium.org/1830833002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:696: if (endpointNumber
<= 0 || endpointNumber >= 16) {
endpointNumber is uint8_t, checking < 0 seems redundant.

https://codereview.chromium.org/1830833002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:725: if
(parameters.requestType() == "standard") {
maybe can use a variable to store parameters.requestType() since it is used
multiple times.

https://codereview.chromium.org/1830833002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:736: if
(parameters.recipient() == "device") {
ditto for parameters.recipient().

[Reilly Grant (use Gerrit), 2016-03-24 21:00:41]

https://codereview.chromium.org/1830833002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webusb/USBDevice.cpp (right):

https://codereview.chromium.org/1830833002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:457:
setEndpointsForInterface(interfaceIndex, false);
On 2016/03/24 at 17:47:46, juncai wrote:
> nit: add comment for false parameter.

Done.

https://codereview.chromium.org/1830833002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:477:
setEndpointsForInterface(interfaceIndex, false);
On 2016/03/24 at 17:47:46, juncai wrote:
> ditto.

Done.

https://codereview.chromium.org/1830833002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:696: if (endpointNumber
<= 0 || endpointNumber >= 16) {
On 2016/03/24 at 17:47:46, juncai wrote:
> endpointNumber is uint8_t, checking < 0 seems redundant.

Done.

https://codereview.chromium.org/1830833002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:725: if
(parameters.requestType() == "standard") {
On 2016/03/24 at 17:47:46, juncai wrote:
> maybe can use a variable to store parameters.requestType() since it is used
multiple times.

These are simple inline accessors. There is no benefit in assigning them to
local variables as the method call will be completely optimized out by the
compiler.

[juncai, 2016-03-24 21:28:13]

LGTM.

[Reilly Grant (use Gerrit), 2016-03-24 21:32:46]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2016-03-24 21:33:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830833002/20001

[commit-bot: I haz the power, 2016-03-24 23:55:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-24 23:58:35]

Description was changed from

==========
Track USB endpoint state in Blink.

The last in a series of patches putting input validation for the WebUSB
directly into Blink. This one adds bit vectors that track which
endpoints are available given the current set of claimed interfaces and
selected alternate interfaces.

BUG=593164
==========

to

==========
Track USB endpoint state in Blink.

The last in a series of patches putting input validation for the WebUSB
directly into Blink. This one adds bit vectors that track which
endpoints are available given the current set of claimed interfaces and
selected alternate interfaces.

BUG=593164

Committed: https://crrev.com/6cfa6305dc22be1489cec97f8ddcf595d75f2a75
Cr-Commit-Position: refs/heads/master@{#383194}
==========

[commit-bot: I haz the power, 2016-03-24 23:58:36]

Patchset 2 (id:??) landed as
https://crrev.com/6cfa6305dc22be1489cec97f8ddcf595d75f2a75
Cr-Commit-Position: refs/heads/master@{#383194}