chrome/browser/chromeos/drive/file_system_proxy.cc - Issue 18308004: Update CrOS to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/file_system_proxy.cc

Issue 18308004: Update CrOS to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/drive/file_system/operation_test_base.cc ('k') | chrome/browser/chromeos/drive/file_system_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/file_system_proxy.cc

diff --git a/chrome/browser/chromeos/drive/file_system_proxy.cc b/chrome/browser/chromeos/drive/file_system_proxy.cc

index 37845abbcbf6f4960b1863936b32f567ced38a18..1377ff73a8dd9ee05307fe683b3e38294a6ab2c7 100644

--- a/chrome/browser/chromeos/drive/file_system_proxy.cc

+++ b/chrome/browser/chromeos/drive/file_system_proxy.cc

@@ -61,11 +61,11 @@ void RunSnapshotFileCallback(

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

scoped_refptr<webkit_blob::ShareableFileReference> file_reference =

- webkit_blob::ShareableFileReference::GetOrCreate(

- webkit_blob::ScopedFile(

- local_path, scope_out_policy,

- BrowserThread::GetMessageLoopProxyForThread(

- BrowserThread::FILE)));

+ webkit_blob::ShareableFileReference::GetOrCreate(webkit_blob::ScopedFile(

+ local_path,

+ scope_out_policy,

+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE)

+ .get()));

callback.Run(error, file_info, local_path, file_reference);

}

@@ -427,7 +427,7 @@ void FileSystemProxy::OnCreateWritableSnapshotFile(

file_ref = ShareableFileReference::GetOrCreate(

local_path,

ShareableFileReference::DONT_DELETE_ON_FINAL_RELEASE,

- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE));

+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE).get());

file_ref->AddFinalReleaseCallback(

base::Bind(&FileSystemProxy::CloseWritableSnapshotFile,

this,